Skip to content

Commit

Permalink
fix: Add missing return in main (#11786)
Browse files Browse the repository at this point in the history
AztecProtocol/aztec-packages#10217 introduced a
bug where the verifier result would not be sent from bb main as a
signal. This triggers a mysterious error in the ivc-integration tests
suite, native only, but does not break any e2e tests. More investigation
is necessary, and ultimately this should be resolved in the ACIR tests,
but it feels prudent now to fix the bug and reinstate the tests later.
  • Loading branch information
codygunton authored and AztecBot committed Feb 8, 2025
1 parent fc71f9f commit a065078
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cpp/src/barretenberg/bb/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1409,7 +1409,7 @@ int main(int argc, char* argv[])
if (command == "write_arbitrary_valid_proof_and_vk_to_file") {
const std::filesystem::path output_dir = get_option(args, "-o", "./target");
api.write_arbitrary_valid_proof_and_vk_to_file(flags, output_dir);
return 1;
return 0;
}

throw_or_abort("Invalid command passed to execute_command in bb");
Expand All @@ -1424,7 +1424,7 @@ int main(int argc, char* argv[])

if (proof_system == "client_ivc") {
ClientIVCAPI api;
execute_command(command, flags, api);
return execute_command(command, flags, api);
} else if (command == "prove_and_verify") {
return proveAndVerify(bytecode_path, recursive, witness_path) ? 0 : 1;
} else if (command == "prove_and_verify_ultra_honk") {
Expand Down

0 comments on commit a065078

Please sign in to comment.