Rename DISABLE_TBB flag and disable on MacOS by default #9747
Conversation
|
Nit: I would prefer if this were PAR_ALGOS |
Will change.
Is this library supposed to be compiled with homebrew llvm16 on macOs? The docs don't really specify and Apple ships LLVM 16 with the latest Xcode. If so, I can also update the readme. As for tighter checks, I see two avenues:
|
|
It could be documented for sure, mac support tends to lag because so many people use a big ol' Linux shared computer. Appreciate the readme update and yeah checking for apple clang works for me! |
|
Added a note in the readme, made the check specific to |
| @@ -31,7 +31,7 @@ option(DISABLE_AZTEC_VM "Don't build Aztec VM (acceptable if iterating on core p | |||
| option(MULTITHREADING "Enable multi-threading" ON) | |||
| option(OMP_MULTITHREADING "Enable OMP multi-threading" OFF) | |||
| option(FUZZING "Build ONLY fuzzing harnesses" OFF) | |||
| option(DISABLE_TBB "Intel Thread Building Blocks" ON) | |||
| option(ENABLE_PAR_ALGOS "Enable parallel algorithms" ON) | |||
There was a problem hiding this comment.
thanks my brain still reads it as a latin language but less so now :D
|
LGTM thanks! |
Per #9746 , mac os compilation on ARM fails by default because of `std::execution::par_unseq`. This PR fixes that by explicitly disabling it on MacOS since apple clang doesn't support it. There's probably a better plug somewhere but I'm not ultra-familiar with how you setup the build system, should this be a preset, should this be based on apple-clang specifically, etc. Can adapt the PR as needed. I also rename DISABLE_TBB here because it seems to me that this should be part of the native C++20 support on other platforms, but I have to admit I'm really unfamiliar with the details here and I'm not sure if intel TBB is needed, or indeed what it does exactly. Can cut this from the PR. Likewise, this turns parallel algorithms ON by default on the same C++20 assumption, but that could well not work.
Per #9746 , mac os compilation on ARM fails by default because of
std::execution::par_unseq.This PR fixes that by explicitly disabling it on MacOS since apple clang doesn't support it. There's probably a better plug somewhere but I'm not ultra-familiar with how you setup the build system, should this be a preset, should this be based on apple-clang specifically, etc. Can adapt the PR as needed.
I also rename DISABLE_TBB here because it seems to me that this should be part of the native C++20 support on other platforms, but I have to admit I'm really unfamiliar with the details here and I'm not sure if intel TBB is needed, or indeed what it does exactly. Can cut this from the PR.
Likewise, this turns parallel algorithms ON by default on the same C++20 assumption, but that could well not work.