Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kind on sepolia + balance consolidation + sepolia values service indices #12473

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Mar 5, 2025

  • update test_kind to correctly get the new L1 mnemonic
  • add consolidate script inside job definition bc post-delete means the files are no longer available for copying (still kept inside spartan/scripts bc it can be useful on its own)
  • enable arbitrary key index start values for validator, prover, bots in values files & remove overrides in sepolia-related yamls

@spypsy spypsy marked this pull request as ready for review March 5, 2025 12:27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete this file if it's now copied into the heml template? Or can we embed it somehow, to avoid having it duplicated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think there's a 'nice' way to embed it. I kept it just bc it may still be useful to be run ad-hoc sometimes but can delete

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's throw in a comment in both places about it being duplicated then, so future us don't accidentally change one but not the other

Comment on lines 38 to 40
set -exu

mnemonic=$1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-x and mnemonic makes me scared :-P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update but also since we're emptying the accounts of this mnemonic so even if it's leaked, it'd be a bunch of empty wallets 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we reuse it again!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be reused ever, we generate a new one for each run! removed now anyway

@spypsy spypsy changed the title fix: kind on sepolia + balance consolidation fix: kind on sepolia + balance consolidation + sepolia values service indices Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants