-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: kind on sepolia + balance consolidation + sepolia values service indices #12473
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we delete this file if it's now copied into the heml template? Or can we embed it somehow, to avoid having it duplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think there's a 'nice' way to embed it. I kept it just bc it may still be useful to be run ad-hoc sometimes but can delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's throw in a comment in both places about it being duplicated then, so future us don't accidentally change one but not the other
set -exu | ||
|
||
mnemonic=$1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-x and mnemonic makes me scared :-P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will update but also since we're emptying the accounts of this mnemonic so even if it's leaked, it'd be a bunch of empty wallets 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until we reuse it again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be reused ever, we generate a new one for each run! removed now anyway
post-delete
means the files are no longer available for copying (still kept inside spartan/scripts bc it can be useful on its own)