Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: @aztec/stdlib pt.2 -> remove @aztec/types #12133

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

Thunkar
Copy link
Contributor

@Thunkar Thunkar commented Feb 20, 2025

With granular exports and circular dependencies removed it's not longer necessary!

Remaining types were moved to circuits.js (soon to be stdlib), but the hasher will probably get pruned since it's only used by the old merkle tree implementation

thunkar and others added 2 commits February 20, 2025 11:10
@Thunkar Thunkar self-assigned this Feb 20, 2025
@Thunkar Thunkar requested a review from charlielye as a code owner February 20, 2025 11:28
@Thunkar Thunkar requested review from ludamad and benesjan and removed request for charlielye February 20, 2025 11:28
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute. LGTM

@Thunkar Thunkar merged commit 3257a97 into master Feb 20, 2025
12 checks passed
@Thunkar Thunkar deleted the gj/remove_types branch February 20, 2025 14:19
TomAFrench added a commit that referenced this pull request Feb 20, 2025
* master: (300 commits)
  fix(ci): don't have checks go green immediately (#12168)
  fix: ASSERTS that should throw (#12167)
  fix: retry rm operation in cleanup (#12162)
  chore: Fix linter errors (#12164)
  feat: Barretenberg C++ binary overhaul (#11459)
  fix: call install_hooks in bootstrap (#12159)
  chore: @aztec/stdlib pt. 3: aztec-address out of foundation (#12140)
  test: verify proving is resumed after broker crash (#11122)
  chore(ci3): update ci.md with swc notes (#12147)
  fix: don't try to get bench artifacts on external PR (#12157)
  feat: partial note handling in aztec-nr (#12122)
  fix: external fixes pt 2 (#12153)
  chore: fix message path (#12150)
  chore(ci3): refactor ci3.yml, fix external PR flow (#12037)
  fix: Do not try flushing txs in bot setup if not set (#12144)
  chore: Silence warns on invalid bootnode enr (#12135)
  fix: don't early-out on test fails (#12143)
  feat(avm): deduplicating event emitters (#12137)
  chore: @aztec/stdlib pt.2 -> remove @aztec/types (#12133)
  test: kill prover node and see it recover (#11118)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants