Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redo typo PR by Daulox92 #11458

Merged
merged 2 commits into from
Jan 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion barretenberg/acir_tests/headless-test/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ program
"Specify the path to the gzip encoded ACIR witness",
"./target/witness.gz"
)
.action(async ({ bytecodePath, witnessPath, recursive }) => {
.action(async ({ bytecodePath, witnessPath, }) => {
const acir = readBytecodeFile(bytecodePath);
const witness = readWitnessFile(witnessPath);
const threads = Math.min(os.cpus().length, 16);
Expand Down
6 changes: 3 additions & 3 deletions barretenberg/acir_tests/run_acir_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ export BIN CRS_PATH VERBOSE BRANCH RECURSIVE
cd acir_tests

# Convert them to array
# There are no issues witht the tests below but as they check proper handling of dependencies or circuits that are part of a workspace
# running these require extra gluecode so they are skipped for the purpose of this script
# There are no issues with the tests below but as they check proper handling of dependencies or circuits that are part of a workspace
# running these require extra glue code so they are skipped for the purpose of this script
SKIP_ARRAY=(diamond_deps_0 workspace workspace_default_member)

# TODO(https://github.com/AztecProtocol/barretenberg/issues/1108): problem regardless the proof system used
Expand Down Expand Up @@ -147,4 +147,4 @@ if [ -f "$error_file" ]; then
rm "$error_file"
echo "Error occurred in one or more child processes. Exiting..."
exit 1
fi
fi
2 changes: 1 addition & 1 deletion barretenberg/cpp/docs/Fuzzing.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ The purpose of each parameter:
- -shrink=1 - If a new testcase is encountered that has the same coverage as some previous one in the corpus and the testcase is smaller, replace the one in the corpus with the new one. Helps keep exec/s higher.
- -artifact_prefix=crashes/ - Where to save crashes/timeouts/ooms.
- -use_value_profile=1 - Leverage libfuzzer internal CMP analysis. Very useful, but blows the corpus up.
- <PATH_TO_CORPUS> (../../../<fuzzer_type>\_testcases) - The path to the folder, where corpus testcases are going to be saved and loaded from (also loads testcases from there at the start of fuzzing).
- <PATH_TO_CORPUS> (`../../../<fuzzer_type>_testcases`) - The path to the folder, where corpus testcases are going to be saved and loaded from (also loads testcases from there at the start of fuzzing).

Log structure is described here https://llvm.org/docs/LibFuzzer.html

Expand Down
4 changes: 2 additions & 2 deletions barretenberg/cpp/installation/bbup
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ main() {

# Reject unsupported architectures.
if [ "${ARCHITECTURE}" != "x86_64" ] && [ "${ARCHITECTURE}" != "aarch64" ]; then
err "unsupported architecure: $ARCHITECTURE-$PLATFORM"
err "unsupported architecture: $ARCHITECTURE-$PLATFORM"
fi

BBUP_TAG=$BBUP_VERSION
Expand Down Expand Up @@ -114,4 +114,4 @@ ensure() {
if ! "$@"; then err "command failed: $*"; fi
}

main "$@" || exit 1
main "$@" || exit 1
6 changes: 3 additions & 3 deletions barretenberg/cpp/pil/avm/gadgets/mem_slice.pil
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ namespace slice(256);
// a memory operation. The following relations ensure that exactly one operation
// selector sel_cd_cpy/sel_return is activated per row with a non-zero counter and
// that within a given operation the pertaining selector is enabled. (One prevents
// to activate sel_return during a callatacopy operation and vice-versa.)
// to activate sel_return during a calldatacopy operation and vice-versa.)

sel_mem_active = sel_cd_cpy + sel_return;

// Instruction decomposition guarantees that sel_cd_cpy and sel_return are mutually exclusive on
// the first row of the calldatcopy/return operation.
// the first row of the calldatacopy/return operation.

// Show that cnt != 0 <==> sel_mem_active == 1
// one_min_inv == 1 - cnt^(-1) if cnt != 0 else == 0
Expand Down Expand Up @@ -76,4 +76,4 @@ namespace slice(256);
// In such a case, we have to disable tag check specifically for RETURN opcode.

#[LOOKUP_RET_VALUE]
sel_return {col_offset, val} in main.sel_returndata {main.clk, main.returndata};
sel_return {col_offset, val} in main.sel_returndata {main.clk, main.returndata};
Loading