feat: Sync from noir (#12176)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: Sync from aztec-packages (noir-lang/noir#7474) fix: don't panic when shifting too much (noir-lang/noir#7429) chore: bump external pinned commits (noir-lang/noir#7472) chore: remove `disable_macros` compile option (noir-lang/noir#7468) chore(ci): add workflow to automate bumping aztec-packages commit (noir-lang/noir#7465) chore: Release Noir(1.0.0-beta.3) (noir-lang/noir#7346) chore(ci): Missing dash in profiler command argument (noir-lang/noir#7467) feat(experimental): show macro errors where they happen (noir-lang/noir#7333) feat: optimize FieldElement::num_bits (noir-lang/noir#7147) chore(profiler): Docs on profiler command and more complete error reporting (noir-lang/noir#7436) feat(ci): Release noir-inspector in binaries (noir-lang/noir#7464) chore(docs): Noir Profiler external documentation (noir-lang/noir#7457) feat(ci): Publish binaries for noir-profiler (noir-lang/noir#7443) chore: Copy #7387 docs into v1.0.0-beta.2 versioned_docs (noir-lang/noir#7458) fix: prevent incorrect ACIRgen caused by noop truncations (noir-lang/noir#7456) feat: add native `u128` type (noir-lang/noir#7301) chore: standardize that doc comments on top of statements and expression are allowed but warn (noir-lang/noir#7450) fix: don't let nargo fmt produce multiple trailing newlines (noir-lang/noir#7444) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch>
AztecProtocol · Feb 21, 2025 · ed9a416 · ed9a416
1 parent 436def3
commit ed9a416
Show file tree

Hide file tree

Showing 390 changed files with 19,898 additions and 2,873 deletions.
diff --git a/.noir-sync-commit b/.noir-sync-commit
@@ -1 +1 @@
-fdfe2bf752771b9611dc71953d50423b4ae7ec44
+c254c3ca07c65c7845d5affb17cb37114c5a3051
diff --git a/avm-transpiler/Cargo.lock b/avm-transpiler/Cargo.lock
diff --git a/noir-projects/aztec-nr/aztec/src/encrypted_logs/mod.nr b/noir-projects/aztec-nr/aztec/src/encrypted_logs/mod.nr
@@ -1,3 +1,2 @@
 pub mod encrypt;
 pub mod log_assembly_strategies;
-
diff --git a/noir-projects/aztec-nr/aztec/src/history/note_validity.nr b/noir-projects/aztec-nr/aztec/src/history/note_validity.nr
@@ -30,4 +30,3 @@ impl ProveNoteValidity for BlockHeader {
         self.prove_note_not_nullified(retrieved_note, storage_slot, context);
     }
 }
-
diff --git a/noir-projects/aztec-nr/aztec/src/macros/dispatch/mod.nr b/noir-projects/aztec-nr/aztec/src/macros/dispatch/mod.nr
@@ -182,4 +182,3 @@ comptime fn get_type<T>() -> Type {
     let t: T = std::mem::zeroed();
     std::meta::type_of(t)
 }
-
diff --git a/noir-projects/aztec-nr/aztec/src/macros/functions/call_interface_stubs.nr b/noir-projects/aztec-nr/aztec/src/macros/functions/call_interface_stubs.nr
@@ -242,4 +242,3 @@ comptime fn create_public_static_void_stub(f: FunctionDefinition) -> Quoted {
         }
     }
 }
-
diff --git a/noir-projects/aztec-nr/aztec/src/utils/field.nr b/noir-projects/aztec-nr/aztec/src/utils/field.nr
@@ -198,4 +198,3 @@ unconstrained fn test_is_square() {
 unconstrained fn test_is_not_square() {
     assert(!is_square(10));
 }
-
diff --git a/noir-projects/mock-protocol-circuits/crates/app-creator/src/main.nr b/noir-projects/mock-protocol-circuits/crates/app-creator/src/main.nr
@@ -7,4 +7,3 @@ fn main(commitments_to_create: [Field; MAX_COMMITMENTS_PER_CALL]) -> return_data
     result.commitments = commitments_to_create;
     result
 }
-
diff --git a/noir-projects/mock-protocol-circuits/crates/app-reader/src/main.nr b/noir-projects/mock-protocol-circuits/crates/app-reader/src/main.nr
@@ -9,4 +9,3 @@ fn main(
     result.read_requests = commitments_to_read;
     result
 }
-
diff --git a/noir-projects/mock-protocol-circuits/crates/mock-private-kernel-init/src/main.nr b/noir-projects/mock-protocol-circuits/crates/mock-private-kernel-init/src/main.nr
@@ -14,4 +14,3 @@ fn main(
     private_kernel_inputs.ingest_app_inputs(app_inputs);
     private_kernel_inputs.finish()
 }
-
diff --git a/noir-projects/mock-protocol-circuits/crates/mock-private-kernel-inner/src/main.nr b/noir-projects/mock-protocol-circuits/crates/mock-private-kernel-inner/src/main.nr
@@ -17,4 +17,3 @@ fn main(
     private_kernel_inputs.ingest_app_inputs(app_inputs);
     private_kernel_inputs.finish()
 }
-
diff --git a/noir-projects/mock-protocol-circuits/crates/mock-private-kernel-reset/src/main.nr b/noir-projects/mock-protocol-circuits/crates/mock-private-kernel-reset/src/main.nr
@@ -23,4 +23,3 @@ fn main(
     }
     prev_kernel_public_inputs
 }
-
diff --git a/noir-projects/mock-protocol-circuits/crates/mock-private-kernel-tail/src/main.nr b/noir-projects/mock-protocol-circuits/crates/mock-private-kernel-tail/src/main.nr
@@ -17,4 +17,3 @@ fn main(
 
     KernelPublicInputs { commitments: prev_kernel_public_inputs.commitments }
 }
-
diff --git a/noir-projects/mock-protocol-circuits/crates/mock-types/src/lib.nr b/noir-projects/mock-protocol-circuits/crates/mock-types/src/lib.nr
@@ -109,4 +109,3 @@ impl Default for KernelPublicInputs {
         Self { commitments: [0; MAX_COMMITMENTS_PER_TX] }
     }
 }
-
diff --git a/noir-projects/noir-contracts/contracts/ecdsa_k_account_contract/src/main.nr b/noir-projects/noir-contracts/contracts/ecdsa_k_account_contract/src/main.nr
@@ -79,4 +79,3 @@ pub contract EcdsaKAccount {
         )
     }
 }
-
diff --git a/noir-projects/noir-contracts/contracts/nft_contract/src/main.nr b/noir-projects/noir-contracts/contracts/nft_contract/src/main.nr
@@ -399,4 +399,3 @@ pub contract NFT {
     }
     // docs:end:get_private_nfts
 }
-
diff --git a/noir-projects/noir-protocol-circuits/crates/blob/src/blob.nr b/noir-projects/noir-protocol-circuits/crates/blob/src/blob.nr
@@ -668,4 +668,3 @@ mod tests {
         }
     }
 }
-
diff --git a/...rivate-kernel-lib/src/components/private_call_data_validator/validate_contract_address.nr b/...rivate-kernel-lib/src/components/private_call_data_validator/validate_contract_address.nr
@@ -93,4 +93,3 @@ pub fn validate_contract_address(
         protocol_contract_tree_root,
     );
 }
-
diff --git a/noir-projects/noir-protocol-circuits/crates/private-kernel-reset-simulated/src/main.nr b/noir-projects/noir-protocol-circuits/crates/private-kernel-reset-simulated/src/main.nr
@@ -37,4 +37,3 @@ unconstrained fn main(
         PRIVATE_LOG_SILOING_AMOUNT,
     )
 }
-
diff --git a/noir-projects/noir-protocol-circuits/crates/private-kernel-reset/src/main.nr b/noir-projects/noir-protocol-circuits/crates/private-kernel-reset/src/main.nr
@@ -37,4 +37,3 @@ fn main(
         PRIVATE_LOG_SILOING_AMOUNT,
     )
 }
-
diff --git a/noir-projects/noir-protocol-circuits/crates/rollup-lib/src/base/state_diff_hints.nr b/noir-projects/noir-protocol-circuits/crates/rollup-lib/src/base/state_diff_hints.nr
@@ -25,4 +25,3 @@ pub(crate) struct PrivateBaseStateDiffHints {
     pub(crate) fee_write_low_leaf_membership_witness: MembershipWitness<PUBLIC_DATA_TREE_HEIGHT>,
     pub(crate) fee_write_sibling_path: [Field; PUBLIC_DATA_TREE_HEIGHT],
 }
-
diff --git a/noir-projects/noir-protocol-circuits/crates/types/src/abis/avm_circuit_public_inputs.nr b/noir-projects/noir-protocol-circuits/crates/types/src/abis/avm_circuit_public_inputs.nr
@@ -235,4 +235,3 @@ fn serialization_of_empty_avm_circuit_public_inputs() {
     let deserialized = AvmCircuitPublicInputs::deserialize(serialized);
     assert(item.eq(deserialized));
 }
-
diff --git a/noir-projects/noir-protocol-circuits/crates/types/src/abis/sponge_blob.nr b/noir-projects/noir-protocol-circuits/crates/types/src/abis/sponge_blob.nr
@@ -140,4 +140,3 @@ unconstrained fn absorb_incorrect_in_len() {
     // The below should fail, as we try to absorb 10 inputs but only provide 3
     spongeblob.absorb(input_3, 10);
 }
-
diff --git a/noir-projects/noir-protocol-circuits/crates/types/src/merkle_tree/variable_merkle_tree.nr b/noir-projects/noir-protocol-circuits/crates/types/src/merkle_tree/variable_merkle_tree.nr
@@ -234,4 +234,3 @@ pub mod tests {
         assert_eq(tree.root, full_tree.get_root());
     }
 }
-
diff --git a/noir-projects/noir-protocol-circuits/crates/types/src/tests/fixtures.nr b/noir-projects/noir-protocol-circuits/crates/types/src/tests/fixtures.nr
@@ -12,4 +12,3 @@ pub global MSG_SENDER: AztecAddress = AztecAddress { inner: 27 };
 pub global CHAIN_ID: Field = 1;
 
 pub global VERSION: Field = 3;
-
diff --git a/noir-projects/noir-protocol-circuits/crates/types/src/utils/arrays/assert_sorted_array.nr b/noir-projects/noir-protocol-circuits/crates/types/src/utils/arrays/assert_sorted_array.nr
@@ -94,4 +94,3 @@ mod tests {
         assert_sorted_array(original, sorted, indexes, |a: Field, b: Field| a.lt(b));
     }
 }
-
diff --git a/noir/noir-repo/.github/benchmark_projects.yml b/noir/noir-repo/.github/benchmark_projects.yml
@@ -1,4 +1,4 @@
-define: &AZ_COMMIT 1350f93c3e9af8f601ca67ca3e67d0127c9767b6
+define: &AZ_COMMIT 481d3beaba9fcc85743919bc640a849dad7b7b88
 projects:
   private-kernel-inner:
     repo: AztecProtocol/aztec-packages

diff --git a/noir/noir-repo/.github/workflows/bump-aztec-packages-commit.yml b/noir/noir-repo/.github/workflows/bump-aztec-packages-commit.yml
@@ -0,0 +1,50 @@
+name: Bump external repos pinned commits
+
+on:
+  workflow_dispatch:
+  schedule:
+    # Trigger at 8am on Mondays
+    - cron: '0 8 * * 1'
+
+
+jobs:
+  bump-commit:
+    name: Update external repo pinned commits
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v4
+        with:
+          ref: master
+
+      - name: Check for existing PR
+        id: pr-check
+        run: |
+          set -xue # print commands         
+          PR_URL=$(gh pr list --repo noir-lang/noir --head bump-aztec-packages --json url --jq ".[0].url")
+          echo "pr_url=$PR_URL" >> $GITHUB_OUTPUT
+        env:
+          GH_TOKEN: ${{ github.token }}
+
+      - name: Configure git
+        run: |
+          git config user.name noirwhal
+          git config user.email tomfrench@aztecprotocol.com    
+        
+      - name: Update commit
+        run: |
+          git checkout bump-aztec-packages || git checkout -b bump-aztec-packages
+          ./scripts/bump-aztec-packages-commit.sh
+          git add .
+          git commit -m 'chore: Update pinned commit of aztec-packages'
+          git push --set-upstream origin bump-aztec-packages --force
+
+      - name: Create PR
+        if: ${{ steps.pr-check.outputs.pr_url == '' }}
+        run: |
+          PR_BODY="""
+          Automated update of the pinned commit of [aztec-packages](https://github.com/AztecProtocol/aztec-packages) repository against which we run benchmarks.
+          """
+          gh pr create --repo noir-lang/noir --title "chore: bump external pinned commits" --body "$PR_BODY" --base master --head bump-aztec-packages
+        env:
+          GH_TOKEN: ${{ secrets.NOIR_REPO_TOKEN }}
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		fdfe2bf752771b9611dc71953d50423b4ae7ec44
		c254c3ca07c65c7845d5affb17cb37114c5a3051
Original file line number	Diff line number	Diff line change
		@@ -1,3 +1,2 @@
		pub mod encrypt;
		pub mod log_assembly_strategies;
Original file line number	Diff line number	Diff line change
Expand Up		@@ -30,4 +30,3 @@ impl ProveNoteValidity for BlockHeader {
		self.prove_note_not_nullified(retrieved_note, storage_slot, context);
		}
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -182,4 +182,3 @@ comptime fn get_type<T>() -> Type {
		let t: T = std::mem::zeroed();
		std::meta::type_of(t)
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -242,4 +242,3 @@ comptime fn create_public_static_void_stub(f: FunctionDefinition) -> Quoted {
		}
		}
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -198,4 +198,3 @@ unconstrained fn test_is_square() {
		unconstrained fn test_is_not_square() {
		assert(!is_square(10));
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,4 +7,3 @@ fn main(commitments_to_create: [Field; MAX_COMMITMENTS_PER_CALL]) -> return_data
		result.commitments = commitments_to_create;
		result
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -9,4 +9,3 @@ fn main(
		result.read_requests = commitments_to_read;
		result
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -14,4 +14,3 @@ fn main(
		private_kernel_inputs.ingest_app_inputs(app_inputs);
		private_kernel_inputs.finish()
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -17,4 +17,3 @@ fn main(
		private_kernel_inputs.ingest_app_inputs(app_inputs);
		private_kernel_inputs.finish()
		}