Skip to content

Commit

Permalink
feat(avm): restrict bytecode bytes (#11798)
Browse files Browse the repository at this point in the history
Added "range check".
  • Loading branch information
fcarreiro authored Feb 7, 2025
1 parent c5c3f09 commit be382bc
Show file tree
Hide file tree
Showing 5 changed files with 78 additions and 9 deletions.
4 changes: 2 additions & 2 deletions barretenberg/cpp/pil/vm2/bc_decomposition.pil
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ last_of_contract * (1 - last_of_contract) = 0;
// If the TX uses several bytecodes, they should go one after the other in this column.
pol commit bytes;
// This constrains that the bytes are in the range 0 to 255.
// #[LOOKUP_BYTECODE_BYTES]
// sel { bytes } in precomputed.sel_u8 { precomputed.clk }
#[LOOKUP_BYTECODE_BYTES_ARE_BYTES]
sel { bytes } in precomputed.sel_range_8 { precomputed.clk };

// These are helper columns that will be used for bytecode decomposition.
pol commit bytes_pc_plus_1, bytes_pc_plus_2, bytes_pc_plus_3, bytes_pc_plus_4, bytes_pc_plus_5,
Expand Down
Loading

1 comment on commit be382bc

@AztecBot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: be382bc Previous: a6fcdb0 Ratio
wasmconstruct_proof_ultrahonk_power_of_2/20 14368.568916 ms/iter 13365.554094 ms/iter 1.08

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

Please sign in to comment.