Don't save paths starting with /start, since they cannot be resumed

[scruffian]

The signup flow can't be resumed in the desktop app, so we shouldn't save these routes in LAST_LOCATION.

The original idea was to exclude all routes when logged out. I couldn't find a way to determine if the user was logged in, and I noticed that the signup flow couldn't be resumed when the use was logged in either, so this fix seems better.

Fixes #82

Testing instructions - Logged out

1. Run git checkout fix/82-dont-save-signup-routes and start your server
2. Run git checkout add/signup-in-desktop from within /calypso
3. Ensure you are logged out of the app
4. Navigate part way though the signup flow
5. Close the app
6. Reopen the app and assert that you see the login page

Testing instructions - Logged in (in signup)

1. Run git checkout fix/82-dont-save-signup-routes and start your server
2. Run git checkout add/signup-in-desktop from within /calypso
3. Ensure you are logged in to the app
4. Navigate part way though the signup flow
5. Close the app
6. Reopen the app and assert that you are taken to the last page you had open (before the signup flow)

Testing instructions - Logged in (not in signup)

1. Run git checkout fix/82-dont-save-signup-routes and start your server
2. Run git checkout add/signup-in-desktop from within /calypso
3. Ensure you are logged in to the app
4. Navigate to a page in Calypso that isn't in the signup flow
5. Close the app
6. Reopen the app and assert that you are taken to the last page you had open

Reviews

• Code
• Product

[drewblaisdell]

When testing, we need to check out the add/signup-in-desktop branch from within calypso/, right?

The code looks good to me, and it works as expected. I'll leave 'Product' unchecked for now.

[scruffian]

When testing, we need to check out the add/signup-in-desktop branch from within calypso/, right?

I updated the test description.

[scruffian]

@mjangda suggested in Automattic/wp-calypso#3221 that we should fix the problem and resume signup rather than just not save it...

[fabianapsimoes]

Reopen the app and assert that you are taken to the last page you had open (before the signup flow)

I'm actually taken to the Reader instead of the last page. I think that's fine, but wanted to point it out.

The other two cases work well. Product 👍