-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Themes, Actions: Install WP.com theme on Jetpack action. #9924
Merged
budzanowski
merged 24 commits into
master
from
add/install-action-wpcom-theme-on-jetpack
Dec 19, 2016
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a410e51
Action implementation.
budzanowski 930c1d9
Tracking reducer implementation.
budzanowski f77b40e
Add -wpcom suffix to theme name.
budzanowski b968043
Correct args order.
budzanowski 75a7454
Add tests.
budzanowski bbbe06c
Add reducer tests.
budzanowski 7aa4881
Change implementation to use wpcom suffixed theme as param.
budzanowski 8383169
Implement review findings.
budzanowski b20388b
Adjust tests.
budzanowski 7b62f5c
Adjust after review/discussion.
budzanowski 6b9f117
Fix reducer
ockham c91357a
s/THEME_INSTALL_ON_JETPACK_REQUEST/THEME_INSTALL/g
ockham 8636394
state/themes/actions: Alphabetize imports
ockham bcd17c4
state/themes/reducer: Rename installThemeOnJetpackRequests to themeIn…
ockham 12e07c4
Fix test
ockham 8388019
More installThemeOnJetpackRequests -> themeInstalls renaming
ockham c180a5f
Alphabetize more
ockham d6bf171
s/installWpcomThemeOnJetpack/installTheme/g
ockham 6247c43
state/themes/test/actions: Use site IDs instead of slugs
ockham a3ea52e
state/themes/actions: Change arg order
ockham 93f8e82
s/wpcomThemeId/themeId/g
ockham 8c5a262
Update JSDoc
ockham 12c6d10
More wpcomThemeId -> themeId renaming
ockham dbf0a0a
state/themes/test/reducer: Use site IDs instead of slugs
ockham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could dispatch
receiveTheme
with the API result here if we want.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am adding it but It looks like we do only receive limited subset of theme data from the endpoint.