Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPC: add instructions link #9416

Merged
merged 4 commits into from
Dec 16, 2016
Merged

JPC: add instructions link #9416

merged 4 commits into from
Dec 16, 2016

Conversation

johnHackworth
Copy link
Contributor

Fixes #9307

This PR adds a link that mirrors the modal window button action to the example screenshots of the jetpack install / activation instructions

image

How to test

  1. You need a self-hosted site without an installed jetpack (or a not active one)
  2. Go to http://calypso.localhost:3000/jetpack/connect and enter the url of your site
  3. You should get a modal window with some instructions on how to get your jetpack on
  4. Click on any of the images. They should take you to the first step of the process in your wp-admin

ping @rickybanister @keoshi @jeffgolenski

@johnHackworth johnHackworth added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 16, 2016
@johnHackworth johnHackworth added this to the Jetpack NUX m2 milestone Nov 16, 2016
@johnHackworth johnHackworth self-assigned this Nov 16, 2016
@matticbot
Copy link
Contributor

@keoshi
Copy link
Contributor

keoshi commented Nov 16, 2016

Works beautifully on my end!

@rickybanister
Copy link

Can we add a hover state to the cards?

It could be nice to use the hover style we used to use on Reader cards for this.

@keoshi do you have another idea for a card hover style based on your new 'add new site' designs?

@keoshi
Copy link
Contributor

keoshi commented Nov 16, 2016

@rickybanister hm, what are trying to solve by having a card hover state? Shouldn't the button still be the primary action on this view? Speaking of which, we should probably add more margin-top to it, so it has more whitespace around and better visibility?

@johnHackworth
Copy link
Contributor Author

@rickybanister @keoshi I added the reader cards hover shadow:

image

@johnHackworth johnHackworth force-pushed the add/jpc-instructions-link branch from 8659a96 to 4f9e344 Compare November 22, 2016 12:33
@keoshi
Copy link
Contributor

keoshi commented Nov 22, 2016

I see a different styling, but looks good to me!

screen shot 2016-11-22 at 12 39 09

@rickybanister
Copy link

@keoshi are you still concerned with styling the hover state? My thought was we might as well make the entire page an anchor since there is only one way forward from here. I don't care if users click the primary button or the images as long as they are able to do what they want to do.

We're also talking about trying other approaches than manual install, so let's just see how this goes for now? We can track clicks on the images as well.

@keoshi
Copy link
Contributor

keoshi commented Nov 22, 2016

Not really, once I tried the interface it worked for me, so I think it makes sense. :)

One caveat though is that the hover is for the entire card, which doesn't behave as a big link, but rather the graphics inside each one. Either way, I like to have a focused area as the user explores the page that emphasizes one step at a time.

@rickybanister
Copy link

Ah, you're totally right. We can adjust that. @johnHackworth I'll handle moving the hover to the image—it should only wrap the browser. I forgot that we had other links in our descriptive text.

@johnHackworth
Copy link
Contributor Author

ping @rickybanister ! did you manage to free some time to work on this?

@rickybanister
Copy link

@johnHackworth I'm going to have @keoshi take a look now, sorry for the massive delay.

@keoshi
Copy link
Contributor

keoshi commented Dec 6, 2016

Updated the styles to reflect the hover state only on the browser portion:

image

Would appreciate if you could give this a quick review when you have time, @johnHackworth.

@rickybanister
Copy link

I think this is definitely a better solution, sorry for suggesting the previous boondoggle.

The darker blue/gray border might be a little heavy however. What if we used more of the diffuse shadow that you (@keoshi) used in your recent Add New WordPress landing page?

@keoshi
Copy link
Contributor

keoshi commented Dec 6, 2016

@rickybanister tried it with a subtler yet larger box-shadow and it really didn't work or/and wasn't visible enough. I can try refining it further though.

Edit: I think it's worth clarifying it — on the Add New WordPress page we have white on very light blue, which lets the drop shadow pop out, but here we have many different elements that render that shadow invisible unless it's almost jarring.

@rickybanister
Copy link

Sounds good @keoshi, this is much better than what we have so let's get it merged.

@rickybanister rickybanister added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 12, 2016
@rickybanister rickybanister merged commit d0010e6 into master Dec 16, 2016
@rickybanister rickybanister deleted the add/jpc-instructions-link branch December 16, 2016 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants