-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JPC: add instructions link #9416
Conversation
Works beautifully on my end! |
Can we add a hover state to the cards? It could be nice to use the hover style we used to use on Reader cards for this. @keoshi do you have another idea for a card hover style based on your new 'add new site' designs? |
@rickybanister hm, what are trying to solve by having a card hover state? Shouldn't the button still be the primary action on this view? Speaking of which, we should probably add more |
@rickybanister @keoshi I added the reader cards hover shadow: |
8659a96
to
4f9e344
Compare
@keoshi are you still concerned with styling the hover state? My thought was we might as well make the entire page an anchor since there is only one way forward from here. I don't care if users click the primary button or the images as long as they are able to do what they want to do. We're also talking about trying other approaches than manual install, so let's just see how this goes for now? We can track clicks on the images as well. |
Not really, once I tried the interface it worked for me, so I think it makes sense. :) One caveat though is that the hover is for the entire card, which doesn't behave as a big link, but rather the graphics inside each one. Either way, I like to have a focused area as the user explores the page that emphasizes one step at a time. |
Ah, you're totally right. We can adjust that. @johnHackworth I'll handle moving the hover to the image—it should only wrap the browser. I forgot that we had other links in our descriptive text. |
ping @rickybanister ! did you manage to free some time to work on this? |
@johnHackworth I'm going to have @keoshi take a look now, sorry for the massive delay. |
Updated the styles to reflect the hover state only on the browser portion: Would appreciate if you could give this a quick review when you have time, @johnHackworth. |
I think this is definitely a better solution, sorry for suggesting the previous boondoggle. The darker blue/gray border might be a little heavy however. What if we used more of the diffuse shadow that you (@keoshi) used in your recent Add New WordPress landing page? |
@rickybanister tried it with a subtler yet larger Edit: I think it's worth clarifying it — on the Add New WordPress page we have white on very light blue, which lets the drop shadow pop out, but here we have many different elements that render that shadow invisible unless it's almost jarring. |
Sounds good @keoshi, this is much better than what we have so let's get it merged. |
Fixes #9307
This PR adds a link that mirrors the modal window button action to the example screenshots of the jetpack install / activation instructions
How to test
ping @rickybanister @keoshi @jeffgolenski