Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup: Remove clickable domain row AB test #9309

Merged
merged 8 commits into from
Dec 1, 2016
Merged

Signup: Remove clickable domain row AB test #9309

merged 8 commits into from
Dec 1, 2016

Conversation

coreh
Copy link
Contributor

@coreh coreh commented Nov 11, 2016

This PR makes the clickable row the default implementation, removing the A/B test.

screen shot 2016-11-11 at 17 21 05

To test:

  • Go through a signup flow that has domains (e.g. main)
  • Type something in the domain search bar
  • Verify that list has clickable rows, and that they're rendering/working normally
  • Open A/B test at "Dev" menu
  • Verify domainSuggestionClickableRow is gone

@coreh coreh added NUX [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 11, 2016
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=remove/clickable-row-abtest

@coreh coreh mentioned this pull request Nov 11, 2016
Merged
@coreh coreh force-pushed the remove/clickable-row-abtest branch from c5aac69 to 901863c Compare November 30, 2016 19:10
bisko
bisko approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@bisko bisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@bisko bisko added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2016
@coreh coreh merged commit 335da5d into master Dec 1, 2016
@coreh coreh deleted the remove/clickable-row-abtest branch December 1, 2016 16:30
@klimeryk klimeryk mentioned this pull request Jun 12, 2017
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 30, 2021
Open
@awaisab172 awaisab172 mentioned this pull request Jun 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisko bisko bisko approved these changes

Assignees

@bisko bisko

@michaeldcain michaeldcain

Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. NUX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coreh @matticbot @bisko @michaeldcain