Reader Refresh: rule-pick-canonical-media #9288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d classification - added the rule pick-canonical-media as a replacement for our featured-asset component - modified how we classify cards so that a card featuring a video will not be styled as if it were PHOTO_ONLY
samouri
force-pushed
the
add/reader/refresh-rule-pick-canonical-media
branch
from
22ff283 to
2a6776b
Compare
samouri
added
the
[Status] Needs Review
samouri
changed the title
blowery
reviewed
Nov 11, 2016
| } | ||
|
|
||
| const featuredMedia = find( post.content_media, isCandidateForFeature ); | ||
| const canonicalMedia = find( post.content_media, isCandidateForFeature ); | ||
| post.canonical_media = { ...canonicalMedia }; |
blowery
reviewed
Nov 11, 2016
| if ( ! canonicalImage || post.content_embeds.length === 1 ) { | ||
| displayType ^= DISPLAY_TYPES.FEATURED_VIDEO; | ||
| } | ||
| if ( post.canonical_media && post.canonical_media.mediaType === 'video' ) { |
blowery
reviewed
Nov 11, 2016
| hasShortContent( post ) ) { | ||
| displayType ^= DISPLAY_TYPES.PHOTO_ONLY; | ||
| } | ||
|
|
||
| if ( canonicalImage ) { | ||
| // TODO do we still need aspect logic here and any of these? |
There was a problem hiding this comment.
we may for the old streams.
blowery
removed
the
[Status] Needs Review
blowery
pushed a commit
that referenced
this pull request
Nov 11, 2016
…ge (#9149) * Reader Refresh: Prefer first media in assence of canonical image * addressed some of blowery's offline comments * fixed the height:0 issue BUT now its a UX issue ... * fixed order of Object.assign for height/width * changes needed after eagerly grab height/width landed * added a check for featured images to be large enough based on post_thumbnail * Reader Refresh: rule-pick-canonical-media (#9288) * Reader Refresh: add canonical_media detection as a rule to enable card classification - added the rule pick-canonical-media as a replacement for our featured-asset component - modified how we classify cards so that a card featuring a video will not be styled as if it were PHOTO_ONLY * don't copy the canonical media and only set it to a found value
bisko
pushed a commit
that referenced
this pull request
Nov 16, 2016
…ge (#9149) * Reader Refresh: Prefer first media in assence of canonical image * addressed some of blowery's offline comments * fixed the height:0 issue BUT now its a UX issue ... * fixed order of Object.assign for height/width * changes needed after eagerly grab height/width landed * added a check for featured images to be large enough based on post_thumbnail * Reader Refresh: rule-pick-canonical-media (#9288) * Reader Refresh: add canonical_media detection as a rule to enable card classification - added the rule pick-canonical-media as a replacement for our featured-asset component - modified how we classify cards so that a card featuring a video will not be styled as if it were PHOTO_ONLY * don't copy the canonical media and only set it to a found value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was suggested in here, I've created
rule-pick-canonical-mediato help with post-classification and styling of cards.This also obviates the need for
FeaturedAssetas its own Component.Fixes #9239.
This change is dependent on #9149 landing
To test:
canonical_mediaprop if you check react dev tools