.org Plans: Fix site slug in plan cancellation survey #9207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
|
Code looks solid, and tests are passing. |
|
LGTM! |
roccotripaldi
added
[Status] Ready to Merge
and removed
[Status] Needs Review
mtias
reviewed
Nov 12, 2016
| @@ -130,7 +131,7 @@ const RemovePurchase = React.createClass( { | |||
| notices.success( | |||
| this.translate( '%(productName)s was removed from {{siteName/}}.', { | |||
| args: { productName }, | |||
| components: { siteName: <em>{ selectedSite.slug }</em> } | |||
| components: { siteName: <em>{ slugToUrl( selectedSite.slug ) }</em> } | |||
There was a problem hiding this comment.
This function is doing exactly the same as the domain attribute of the site entity, which is what should be used instead.
selectedSite.domain instead of slugToUrl( selectedSite.slug ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #9200, where the site slug is not properly formatted and displays
::instead of/when the Jetpack site is installed in a subdirectory.To test:
/and not with::in the "Are you sure you want to remove {PLAN} from {SLUG}" text in the removal step/and not with::in the "{PLAN} was removed from {SLUG}" text in the removal confirmation notice.slugToUrlmethod pass:npm run test-client client/lib/url/test/index.js -- --grep "slugToUrl"/cc @beaulebens @johnHackworth