Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guided Tours: Don't require sections due to bundle deps issue #8852

Merged
merged 1 commit into from
Oct 19, 2016

Conversation

mcsf
Copy link
Member

@mcsf mcsf commented Oct 19, 2016

#7908's pathToSection change led to a lot of Calypso chunks unintentionally depending on chunks theme and themes. Fix this by requiring wordpress-com instead of sections while we think of a different approach, potentially using require.ensure.

h/t @blowery @ehg

To test

  • Make sure the "blanket exit" feature introduced in GuidedTours: (blanket) exit by guessing user intent #7908 still works, as well as Guided Tours in general
  • Make sure nothing funky happens during build and that theme and themes are not dependencies of other chunks
  • Make sure all sections load correctly across Calypso

Instead, temporarily require 'wordpress-com' while we think of a
different approach, potentially using 'require.ensure'.
@mcsf mcsf added [Type] Bug When a feature is broken and / or not performing as intended Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Guided Tours labels Oct 19, 2016
@matticbot
Copy link
Contributor

@mcsf mcsf self-assigned this Oct 19, 2016
@lsinger
Copy link
Contributor

lsinger commented Oct 19, 2016

I can confirm that this removes the theme and themes dependencies and that a) GuidedTours still works; b) GuidedTours blanket exit still works; and c) Calypso still works (I checked most sections). 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Guided Tours [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants