Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media: Call correct reset prop on unmount #8818

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Media: Call correct reset prop on unmount #8818

merged 1 commit into from
Oct 18, 2016

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Oct 18, 2016

Regression introduced in #8691

This pull request seeks to resolve an error which can be logged when unmounting the media modal, caused by calling a prop function which does not exist. While resetMediaModalView is the name of the action creator function, in the component's mapDispatchToProps it is renamed to resetView. The changes in this pull request correct this error.

Testing Instructions:

  1. Navigate to the post editor
  2. Select a site, if prompted
  3. Click Add Media in the editor toolbar
  4. Dismiss the modal
  5. Note that no errors are logged to console

@aduth aduth added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Media The media screen in Calypso, general media management, or integration with third party media. labels Oct 18, 2016
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/media-modal-reset-view

@gwwar gwwar added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 18, 2016
@aduth aduth merged commit aa37949 into master Oct 18, 2016
@aduth aduth deleted the fix/media-modal-reset-view branch October 18, 2016 18:58
aduth added a commit that referenced this pull request Oct 18, 2016
@aduth
Revert "Merge pull request #8818 from Automattic/fix/media-modal-rese…
7f8c004 
…t-view"

This reverts commit aa37949, reversing
changes made to fe38e40.
@aduth aduth mentioned this pull request Oct 18, 2016
Closed
aduth added a commit that referenced this pull request Oct 18, 2016
@aduth
Revert "Merge pull request #8818 from Automattic/fix/media-modal-rese…
5d23322 
…t-view"

This reverts commit aa37949, reversing
changes made to fe38e40.
This was referenced Oct 18, 2016
Merged
Closed
aduth added a commit that referenced this pull request Oct 20, 2016
@aduth
Revert "Revert "Merge pull request #8818 from Automattic/fix/media-mo…
97d9fe0 
…dal-reset-view""

This reverts commit 5d23322.
@aduth aduth mentioned this pull request Oct 20, 2016
Merged
aduth added a commit that referenced this pull request Oct 25, 2016
@aduth
Revert "Revert "Merge pull request #8818 from Automattic/fix/media-mo…
af53e11 
…dal-reset-view""

This reverts commit 5d23322.
bisko pushed a commit that referenced this pull request Nov 16, 2016
@aduth @bisko
Revert "Revert "Merge pull request #8818 from Automattic/fix/media-mo…
213ef93 
…dal-reset-view""

This reverts commit 5d23322.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduth @matticbot @gwwar