Advanced SEO: refactor seo settings page #8446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindl
added
[Feature] Site Settings
|
Might not be related to this PR, but I've noticed that the Front page meta description I've set for the site doesn't show up in the preview, it is instead showing the site's tagline. |
|
@roundhill I've reproduced it too and verified that it is not related to this PR. Filed a separate PR that fixes that issue here: #8455 |
|
@vindl looks good to me. I'm going to remove myself from this in case @roundhill has further comments. You have my 👍 |
|
I'm a go |
roundhill
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Remove Search Preview code that is no longer needed and fix ling warnings.
vindl
force-pushed
the
update/seo-settings-cleanup
branch
from
af58c24 to
7d606a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Search Preview code that is no longer needed - it was replaced with
Show Previewsbutton.Also fixes CSS related lint warnings.