Reader: add placeholder for reader-related-card-v2 #8334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefuton
added
[Status] In Progress
[Feature] Reader
samouri
reviewed
Sep 29, 2016
| @@ -60,6 +91,10 @@ export function RelatedPostCard( { post, site, onPostClick = noop, onSiteClick = | |||
| 'has-thumbnail': !! featuredImage | |||
| } ); | |||
|
|
|||
| //if ( ! post || post.state == 'pending' ) { | |||
There was a problem hiding this comment.
why is this commented out?
There was a problem hiding this comment.
For testing only - see todo item above :)
Uncomment logic to only use placeholder when post is missing or still in pending state
Uncommented now!
bluefuton
added
[Status] Needs Review
jancavan
reviewed
Sep 29, 2016
| @@ -442,3 +442,40 @@ $reader-related-card-v2-breakpoint-small: "( max-width: 535px )"; | |||
| max-height: none; | |||
| } | |||
| } | |||
|
|
|||
| // Placeholders | |||
| .reader-related-card-v2.is-placeholder { | |||
There was a problem hiding this comment.
I think we need to nest the .is-modifier instead of the selectors? I'll update it.
There was a problem hiding this comment.
Thanks @jancavan!
There was a problem hiding this comment.
@bluefuton Actually nvm. It doesn't make sense in this case. I tried and we're going to end up with too many .is-modifers.
jancavan
added
[Status] In Progress
[Status] Needs Review
|
The stacked RPs have placeholder images too wide:
I can look into this @bluefuton. |
jancavan
added
[Status] In Progress
and removed
[Status] Needs Review
jancavan
added
[Status] Needs Review
|
@bluefuton Fixed in: 8301f12 Before: After: |
|
Thank you @jancavan! |
|
LGTM 🚢 |
jancavan
added
[Status] Ready to Merge
and removed
[Status] Needs Review
This was referenced Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a placeholder when related posts blocks are loading in the new Reader full post view.
This will help us when we need to scroll to a specific spot on the page before everything's loaded (e.g. for comments anchor #7892).
Outstanding tasks:
pendingstate