Chat component: Add contrast to links #8279
Conversation
This is a tiny PR to adjust the link colors for responses in the chat to show more contrast against their background.
jasmussen
added
[Type] Enhancement
|
Can you add testing instructions and a screenshot please? :) |
|
Great point, sorry for forgetting that. Have updated the post! |
| @@ -284,10 +284,25 @@ | |||
| padding: 0 8px; | |||
| margin: 6px 0; | |||
|
|
|||
| a { | |||
There was a problem hiding this comment.
I think we prefer named class selectors instead of targeting HTML elements. I thought it's written in our CSS guidelines but I can't find it now. :D
There was a problem hiding this comment.
This would be an exception since we don't necessarily control the markup that is rendered in the chats.
There was a problem hiding this comment.
Hmm, how so? If somebody writes a link, we are the ones who control how the link gets rendered; as a a element with this and that props and class names. Or do I get this wrong? Isn't it our service, our code?
| } | ||
|
|
There was a problem hiding this comment.
Do we need this blank line?
|
Thanks for adding the instructions and screenshot! First thing first — the chat is awesome! I'm seeing it for the first time and it's really nice. Great work there! I think the links are legible enough now. Except the two minor things I pointed out, I think this is ready to be merged. |
lamosty
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
|
Whitespace cleanup looks consistent now 👍 |
This is a tiny PR to adjust the link colors for responses in the chat to show more contrast against their background.
Instructions:
make runCalypsoScreenshot: