Purchases: Domain cancellation: confirm button enabled before user co… #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfirmed understanding terms
gziolo
added
[Type] Bug
|
QA and code 👍 I used this a lot while testing cancelations. |
| } ); | ||
| } ); | ||
| form.addEventListener( 'submit', ( event ) => { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
Not directly related to this issue, but should we disable the submit button after it is clicked once?
There was a problem hiding this comment.
@fabianapsimoes do you think we should implement it in v1? It sounds like a nice UX improvement. In v2 we should rather replace this whole Confirm Cancellation page with rewritten version based on design's team prototype.
gziolo
added a commit
that referenced
this pull request
Nov 26, 2015
…d-by-default Purchases: Domain cancellation: confirm button enabled before user co…
gziolo
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nfirmed understanding terms
Fixes #726.
When cancelling a domain, if I select "The service isn't what I expected" / "I meant to get a free blog" / "Something not listed here" in the Confirm Cancellation screen, the Cancel Domain button is enabled right away.
It should only be enabled once the user has checked "I understand that canceling means that I may lose this domain forever".
Testing
Cancel and Refundpage.Confirm Cancel Purchasepage.Note: When you send one request to Cancel Domain Purchase mail is sent. When you go again to Cancel Confirmation page the following message is displayed:
This upgrade cannot be cancelled.
Testing
/cc @fabianapsimoes