Editor: Update sharing container to use selected site from Redux state #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Post/Page Editor
aduth
force-pushed
the
update/editor-sharing-sites-redux
branch
from
5009ac7 to
0f04495
Compare
aduth
added
[Status] Needs Review
|
Rebased to account for #751, which was recently merged. |
| @@ -120,7 +120,7 @@ var EditorDrawer = React.createClass( { | |||
| } | |||
|
|
|||
| return ( | |||
| <EditorSharingContainer site={ this.props.site } currentUserID={ currentUser.ID } /> | |||
|
Tested on Chrome, IE11, Edge. |
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
aduth
force-pushed
the
update/editor-sharing-sites-redux
branch
from
0f04495 to
e69f170
Compare
aduth
added a commit
that referenced
this pull request
Dec 15, 2015
…edux Editor: Update sharing container to use selected site from Redux state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #751This pull request seeks to make use of the new sites module introduced in #751 to eliminate the dependency on the
sites-listsite object passed to the<EditorSharingContainer />component. It also includes the necessary wiring to ensure that the selected site is assigned in the My SitesselectedSitemiddleware function, and that the sites reducers are included in the global reducer.Testing instructions:
Verify that post editor Publicize connections are accurate for the site visited, that no errors are shown in the developer tools console, and that Publicize connections update upon changing the selected site in the post editor.