Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happyblocks: Fix incorrect block name #73987

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

msurdi-a8c
Copy link
Contributor

fixes 318-gh-Automattic/lighthouse-forums

Proposed Changes

There was a misspelling in the block name introduced in #7353 and causing 318-gh-Automattic/lighthouse-forums

Testing Instructions

  • Sync these changes with yarn dev --sync
  • Ensure the related issue is fixed

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@msurdi-a8c msurdi-a8c requested review from wellyshen and a team March 2, 2023 10:17
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

@matticbot
Copy link
Contributor

This PR modifies the release build for happy-blocks

To test your changes on WordPress.com, run install-plugin.sh happy-blocks fix/318-gh-Automattic/lighthouse-forums on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-r7r-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@msurdi-a8c msurdi-a8c merged commit cc671d0 into trunk Mar 2, 2023
@msurdi-a8c msurdi-a8c deleted the fix/318-gh-Automattic/lighthouse-forums branch March 2, 2023 11:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants