Editor: Open window with previewUrl if it failed #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the desktop app `window.open( 'about:blank' )` fails. Add a check for the preview window. If it doesn't exist when we have the previewUrl then directly open the window with the preview URL. It may be possible to just create the window here in the first place but I am not sure if it is split for a reason
johngodley
added
[Status] In Progress
[Feature] WordPress Desktop App
I believe it's to get around pop-up blockers. /cc @aduth for a sanity check? |
Windows cannot be opened in asynchronous callbacks, as the call must occur in the same call stack as a user interaction (i.e. click). This is why we open a popup when the user clicks and redirect after the save finishes. |
johngodley
added
[Status] Needs Review
mjangda
changed the title
mjangda
added
the
[Feature] Post/Page Editor
|
🚢 🚢 🚢 |
mjangda
added
[Status] Ready to Merge
and removed
[Status] Needs Review
johngodley
added a commit
that referenced
this pull request
Dec 11, 2015
Editor: Open window with previewUrl if it failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the desktop app
window.open( 'about:blank' )causes issues, and the Jetpack preview fails.This PR adds a check for
_previewWindow. If it doesn't exist when displaying thepreviewUrlthen directly open the window with thepreviewUrl.Note: it may be possible to just create the window here in the first place but I am not sure if it is split for a reason