Plans: state/plans test deepfreeze fix #6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artpi
added
[Feature] Plans & Upgrades
| @@ -58,10 +58,10 @@ describe( 'reducer', () => { | |||
| const initialState = undefined; | |||
| const plans = getValidDataFromResponse( WPCOM_RESPONSE ); | |||
| const action = plansReceiveAction( plans ); | |||
| const newState = itemsReducer( initialState, action ); | |||
| const expectedState = plans; | |||
There was a problem hiding this comment.
Could we maybe deepFreeze and assign on a single line:
const expectedState = deepFreeze( plans );
|
Thanks for finding and cleaning this up 👍 |
This was referenced Mar 16, 2020
This was referenced Nov 17, 2020
This was referenced Mar 30, 2021
This was referenced Sep 15, 2021
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deepfreeze usage in
state/plans/reducerIt seems that we are deepFreezin after objects have an ability to mutate.
Testing
npm run test-clientCC @gwwar @retrofox
Test live: https://calypso.live/?branch=fix/state-plans-deepfreeze