Guided Tours: exploratory selectors-based tour triggering #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Listening to GUIDED_TOUR_* actions in the trigger logger reducer _may_ be handy later to detect whether user has already seen (completed/dimissed) a tour.
should fix design layout show/hiding not updating preview state
- add relevant triggers - bump up tourTriggers array slice to 50 (so we capture enough actions, hmm) - add getStep in GT selector, which will recursively look at whether to 'skip' showing a step, e.g. if the step's showInContext returns false, or `continueIf` returns true the themes tour mostly works, although i notice a flash of a step, which didn't happen with the middleware approach
So that the action, which will be caught by the `tourTriggers` reducer, can later inform the GT selectors on _which_ tours the user has seen or dismissed.
- 'themes' may be triggered by navigating to Theme Showcase - 'main' may be triggered by navigating anywhere, as long as 'tour=main' query arg is found.
- Rename to 'action log' and rephrase module semantics accordingly - Move from `state.ui.tourTriggers` to `state.currentUser.actionLog` - Split log into two branches: `.permanent` and `.temporary` - Listen to `ACTION_LOG_RECEIVE` to permanently store arbitrary actions - `actions#quitGuidedTour`: add `finished` to dispatched object
|
Proof of concept: remembering which tours have been seen — client-side, via https://cloudup.com/cR-TJ9rBwA6 (screencast w/ audio) |
For ease of debugging
This was referenced Jun 21, 2016
6 tasks
|
@mcsf can we close this one now? |
|
Yep!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5933.
Try a significantly different approach to triggering Guided Tours — particularly, when to trigger and which tours to trigger — and which not to.
TODO: elaborate
Test live: https://calypso.live/?branch=try/guided-tours-trigger-logging