Reader: Pull in stores that accept actions when pre-loading. #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Reader preloads all of a user's subscriptions when you hit any Reader URL. This works pretty well, but we have to ensure that all of the stores that want to listen for and act upon actions fired by the preload are spun up and listening. This patch teaches the controller how to load all of those stores before kicking off the preload.
blowery
added
[Status] Needs Review
|
cc @bluefuton |
|
👍 🚢 |
bluefuton
added
[Status] Ready to Merge
and removed
[Status] Needs Review
bluefuton
added a commit
that referenced
this pull request
Nov 23, 2015
…dness Reader: Pull in stores that accept actions when pre-loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reader preloads all of a user's subscriptions when you hit any Reader URL. This works pretty well, but we have to ensure that all of the stores that want to listen for and act upon actions fired by the preload are spun up and listening.
This patch teaches the controller how to load all of those stores before kicking off the preload.
Fixes #559