Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing: Update receipts to use monospaced font in Receipt and Transaction IDs #56887

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

chrisfromthelc
Copy link
Contributor

@chrisfromthelc chrisfromthelc commented Oct 7, 2021

Changes proposed in this Pull Request

This PR will address concerns in 528-gh-Automattic/payments-shilling, where users or others may easily misread proportional font transaction IDs (swapping I for l for example). Changing the IDs to a monospace font should help with legibility.

Testing instructions

  1. Switch to this branch.
  2. Navigate to a receipt that contains a transaction ID.
  3. You should see the transaction ID displayed in a monospaced font.

Before:
Screen Shot 2021-10-07 at 1 43 57 PM

After:
Screen Shot 2021-10-07 at 1 44 08 PM

Resolves 528-gh-Automattic/payments-shilling

@chrisfromthelc chrisfromthelc added [Feature Group] WPCOM Store & Purchases All things billing on WordPress.com. This includes the backend store, plans, and billing management. Design [Estimate] 1 labels Oct 7, 2021
@chrisfromthelc chrisfromthelc self-assigned this Oct 7, 2021
@chrisfromthelc chrisfromthelc requested a review from a team as a code owner October 7, 2021 20:47
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~9 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-purchases        +62 B  (+0.0%)       +9 B  (+0.0%)
purchases             +62 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@michaeldcain michaeldcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaeldcain michaeldcain added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 7, 2021
@chrisfromthelc chrisfromthelc merged commit 8c8f2d7 into trunk Oct 7, 2021
@chrisfromthelc chrisfromthelc deleted the update/receipt-transaction-id-monospace-font branch October 7, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design [Estimate] 1 [Feature Group] WPCOM Store & Purchases All things billing on WordPress.com. This includes the backend store, plans, and billing management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants