DesignPreview: Refresh iframe the second time the preview is accessed #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehg
force-pushed
the
update/design-preview-refresh
branch
2 times, most recently
from
6d7e243 to
7bf7e40
Compare
ehg
added
[Status] Needs Review
|
Works nicely for me. Code LGTM. Can you prettify the commit message subject a bit and, in the body, add the rationale for a) changing the URL to force a reload and b) using a counter instead of a random string? |
lsinger
added
[Status] Ready to Merge
and removed
[Status] Needs Review
We need a way to refresh the DesignPreview iframe contents after a preview is displayed the second time. We don't have access to the iframe, due to cross-origin concerns, so a way to combat this is to append a counter onto the `previewUrl`. This is done in a way that the first _preloaded_ view does not refresh, however every subsequent view _is_ refreshed — which wouldn't be possible with a random number or timestamp.
ehg
force-pushed
the
update/design-preview-refresh
branch
from
7bf7e40 to
6e87223
Compare
|
Done: 6e87223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can't access the iframe to do a
.reload(), or change thesrc, changing the URL seems to be the only way of refreshing the iframe.DesignPreview, which is incremented if a refresh is needed, and reset on site changeIdeally we'd be able to tell
WebPreviewto refresh the URL somehow, and get rid of the qarg.TODO:
getPreviewUrlcodegetPreviewUrlas a qargTo test: