Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domains: Strip trailing whitespace when setting up Email Forwarding #5544

Merged
merged 1 commit into from
May 31, 2016
Merged

Domains: Strip trailing whitespace when setting up Email Forwarding #5544

merged 1 commit into from
May 31, 2016

Conversation

klimeryk
Copy link
Contributor

@klimeryk klimeryk commented May 24, 2016 •
edited
Loading

@klimeryk klimeryk added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels May 24, 2016
@klimeryk klimeryk self-assigned this May 24, 2016
@klimeryk klimeryk force-pushed the fix/trailing-whitespace-email-forwarding branch from d70fe3e to 626499f Compare May 24, 2016 01:26
@umurkontaci
Copy link
Contributor

Per RFC 5321, local part of mailbox address (before @ sign) must be case sensitive. We can lowercase the domain part but not the local.

@umurkontaci umurkontaci added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 24, 2016
@klimeryk klimeryk force-pushed the fix/trailing-whitespace-email-forwarding branch from 626499f to 356ba39 Compare May 26, 2016 19:04
@klimeryk
Copy link
Contributor Author

Thanks, great catch! After a few iterations, I've given up just focused on the issue at hand - stripping all whitespace from both fields 😁

@klimeryk klimeryk added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Author Reply labels May 26, 2016
@umurkontaci
Copy link
Contributor

LGTM

@umurkontaci umurkontaci added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 30, 2016
@klimeryk klimeryk merged commit bb13146 into master May 31, 2016
@klimeryk klimeryk deleted the fix/trailing-whitespace-email-forwarding branch May 31, 2016 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@klimeryk klimeryk

Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klimeryk @umurkontaci