-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Extract languages to shared config and remove obsolete muse_supported_themes #5413
Conversation
{ "value": 13, "langSlug": "cy", "name": "cy - Cymraeg" }, | ||
{ "value": 14, "langSlug": "da", "name": "da - Dansk" }, | ||
{ "value": 15, "langSlug": "de", "name": "de - Deutsch", "popular": 4 }, | ||
{ "value": 427, "langSlug": "dv", "name": "dv - ދިވެހިބަސް" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone double check if that works properly for users? Everything else displays properly for me, but this one seems to be broken.
I haven't tested the language ones, but it's looking good to me. |
It turned out @akirk can you double check language related change? |
@gziolo wow, I did some digging and the use-case for I'd say removing it is fine. |
@mtias can we land this one? It looks like there are no blockers. |
Yeah, let's 🚢 |
We repeat across all config files so many values. We could easily mitigate that issue by using already present
_shared.json
config file introduced by @mjangda in #876. This PR tries to slim down config files by extractingmuse_supported_themes
andlanguages
fields. We probably can open the follow up PR with more changes.Testing
npm test
and make sure everything passes.http://calypso.localhost:3000/me/account
and make sure you still can change language for your interface :)