Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExPlat: Expose all ExPlat Client Functions #50609

Merged
merged 5 commits into from
Mar 2, 2021

Conversation

jessie-ross
Copy link
Contributor

Changes proposed in this Pull Request

  • Expose all explat client functions including react helpers

Part of a series rebuilding the reference WIP PR #48475 (Although no longer kept in sync).

Testing instructions

  • N/A

@jessie-ross jessie-ross requested a review from yanirs March 2, 2021 04:00
@jessie-ross jessie-ross requested a review from a team as a code owner March 2, 2021 04:00
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 2, 2021
@matticbot
Copy link
Contributor

matticbot commented Mar 2, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~70 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +105 B  (+0.0%)      +31 B  (+0.0%)
entry-login                 +105 B  (+0.0%)      +30 B  (+0.0%)
entry-gutenboarding         +105 B  (+0.0%)      +26 B  (+0.0%)
entry-domains-landing       +105 B  (+0.0%)      +34 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@yanirs yanirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but should fix the unit test failures before merging.

@jessie-ross
Copy link
Contributor Author

🤔 Cannot find module '@automattic/explat-client-react-helpers' from 'lib/explat/index.ts'

@jessie-ross jessie-ross merged commit c8649b1 into trunk Mar 2, 2021
@jessie-ross jessie-ross deleted the add/explat-lib-react-helpers branch March 2, 2021 15:13
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants