Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExPlat: Self-Contained Client Base Package #49502

Merged
merged 3 commits into from
Feb 10, 2021
Merged

ExPlat: Self-Contained Client Base Package #49502

merged 3 commits into from
Feb 10, 2021

Conversation

jessie-ross
Copy link
Contributor

Changes proposed in this Pull Request

  • This PR adds the base package for the ExPlat self-contained package.

Part of a series rebuilding the reference WIP PR #48475

Testing instructions

  • yarn build should run successfully

@jessie-ross jessie-ross requested review from a team and yanirs and removed request for a team January 31, 2021 03:00
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/explat-sac-package-base

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 31, 2021
@jessie-ross jessie-ross requested a review from a team January 31, 2021 03:00
@jessie-ross jessie-ross mentioned this pull request Jan 31, 2021
Closed
9 tasks
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

tyxla
tyxla approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as a placeholder to build on top of 👍

packages/explat-client/.eslintrc.js Outdated
@@ -0,0 +1 @@
module.exports = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to remove that one if we won't be declaring any special eslint rules or exceptions here.

yanirs
yanirs approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@yanirs yanirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to also add a readme to this PR since people who see this won't necessarily know what ExPlat is. Just a title, a one-liner description, and simple build instructions would be a good base for later PRs.

@jessie-ross
Copy link
Contributor Author

It'd be good to also add a readme to this PR since people who see this won't necessarily know what ExPlat is. Just a title, a one-liner description, and simple build instructions would be a good base for later PRs.

Sure I'll add one in, but I was thinking of merging them all together at the end.

@jessie-ross
Copy link
Contributor Author

The desktop and mobile e2e seem to generally fail and are generally ignored.
I will be keeping an eye on their output however to see if there is anything suspicious.

@jessie-ross jessie-ross merged commit 7dbd8b1 into trunk Feb 10, 2021
@jessie-ross jessie-ross deleted the add/explat-sac-package-base branch February 10, 2021 14:24
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanirs yanirs yanirs approved these changes

@tyxla tyxla tyxla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jessie-ross @matticbot @yanirs @tyxla