Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebPreview: fix height of the iframe. #4050

Merged
merged 1 commit into from
Mar 16, 2016

Conversation

mtias
Copy link
Member

@mtias mtias commented Mar 15, 2016

Avoid cutting off part of the previewed page.

Fixes #3707.

See #3901.

@mtias mtias added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Components [Feature] Post/Page Editor The editor for editing posts and pages. labels Mar 15, 2016
@@ -147,7 +147,9 @@

.web-preview__placeholder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an unfortunate name for this element 😕

@aduth
Copy link
Contributor

aduth commented Mar 16, 2016

👍

@aduth aduth added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 16, 2016
mtias added a commit that referenced this pull request Mar 16, 2016
…e-height

WebPreview: fix height of the iframe.
@mtias mtias merged commit 58bd097 into master Mar 16, 2016
@mtias mtias deleted the update/fix-web-preview-iframe-height branch March 16, 2016 20:31
@lancewillett lancewillett removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Components [Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants