Update: Replace site.user_can_manage with site.capabilities && site.capabilities.manage_options #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
API
[Status] Needs Review
|
Nice, thanks for this. I'll let @lezama give it a go ;) |
|
Thanks Enej! 👍 We could use the |
lezama
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
Good call. |
enejb
added
[Status] Needs Review
|
Just updated the code to use userCan. Thanks for the suggestion! |
|
LGTM after rebase 👍 |
lezama
added
[Status] Ready to Merge
and removed
[Status] Needs Review
…apabilities.manage_options We are planning to remove user_can_manage from the endpoint.
enejb
force-pushed
the
remove/user_can_manage
branch
from
ea32f17 to
55bc973
Compare
enejb
added a commit
that referenced
this pull request
Mar 14, 2016
Update: Replace site.user_can_manage with utils.userCan( 'manage_options' );
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning to remove user_can_manage from the endpoint.
To test:
??
Run the API test. Browse though the the admin and try to see if anything is broken.
cc: @lezama and @mtias