People: Fixes RoleSelect issue with localStorage cleared #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Status] Needs Review
| @@ -20,7 +20,7 @@ import sitesList from 'lib/sites-list'; | |||
| /** | |||
| * Module variables | |||
| */ | |||
| const debug = debugFactory( 'calypso:role-select' ); | |||
| const debug = debugFactory( 'calypso:my-sites:people:role-select' ); | |||
lezama
added
[Status] Ready to Merge
and removed
[Status] Needs Review
ebinnion
added a commit
that referenced
this pull request
Feb 24, 2016
…torage People: Fixes RoleSelect issue with localStorage cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3442
Previously, the RoleSelect did not work properly when going to
/people/new/$sitewith a clearedlocalStorage. After some digging, this seems to have been because we were not re-fetching once site was set properly. 😱This PR fixes that by ensuring that we fetch in
componentWillReceiveProps. Note that while we callthis.fetchRoles()each time we receive new props, we do not in fact fetch each time. If a site already has roles,fetchRoles()bails early.To test:
update/people-invites-localstoragebranch/people/new/$sitewhere$siteis a WP.com sitelocalStorage.clear()/people/team/$sitewhere$siteis a WP.com or Jetpack sitecc @lezama for review