Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: alphabetize feature flags #3309

Merged
merged 1 commit into from
Feb 15, 2016
Merged

config: alphabetize feature flags #3309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ console.log( config( 'redirect_uri' ) );
Feature Flags
-------------

The config files contain a features object that can be used to determine whether to enable a feature for certain environments. This allows us to merge in-progress features without launching them to production. The config module adds two methods to detect this: `config.isEnabled()` and `config.anyEnabled()`.
The config files contain a features object that can be used to determine whether to enable a feature for certain environments. This allows us to merge in-progress features without launching them to production. The config module adds two methods to detect this: `config.isEnabled()` and `config.anyEnabled()`. Please make sure to add new feature flags alphabetically so they are easy to find.

```json
{
"features": {
"reader": true,
"manage/posts": true
"manage/posts": true,
"reader": true
}
}
```
Expand Down
29 changes: 14 additions & 15 deletions config/desktop-mac-app-store.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,24 @@
"discover_blog_id": 53424024,
"discover_logged_out_redirect_url": "/",
"features": {
"desktop": true,
"fluid-width": true,
"oauth": true,
"code-splitting": false,
"always_use_logout_url": true,
"press-this": false,
"olark": false,
"login": false,

"ad-tracking": true,
"desktop-promo": false,
"always_use_logout_url": true,
"code-splitting": false,
"community-translator": true,
"desktop": true,
"desktop-promo": false,
"fluid-width": true,
"help": false,
"login": false,
"mailing-lists/unsubscribe": true,
"manage/ads": true,
"manage/ads/jetpack": true,
"manage/customize": true,
"manage/edit-user": true,
"manage/jetpack-plans": true,
"manage/jetpack": true,
"manage/menus-jetpack": true,
"manage/jetpack-plans": true,
"manage/menus": true,
"manage/menus-jetpack": true,
"manage/option_sync_non_public_post_stati": false,
"manage/pages": true,
"manage/people": true,
Expand All @@ -48,8 +44,8 @@
"manage/site-settings/analytics": true,
"manage/site-settings/delete-site": true,
"manage/stats": true,
"manage/themes-jetpack": true,
"manage/themes": true,
"manage/themes-jetpack": true,
"me/account": true,
"me/billing-history": true,
"me/find-friends": false,
Expand All @@ -60,13 +56,17 @@
"me/security/checkup": true,
"me/trophies": false,
"muse": true,
"oauth": true,
"olark": false,
"olark_use_wpcom_configuration": false,
"persist-redux": false,
"phone_signup": true,
"post-editor": true,
"post-editor/author-selector": true,
"post-editor/iframe-preview": true,
"post-editor/live-image-updates": true,
"post-editor/pages": true,
"press-this": false,
"reader": true,
"reader/activities": true,
"reader/discover": true,
Expand All @@ -88,8 +88,7 @@
"upgrades/domain-management/transfer": false,
"upgrades/domain-search": false,
"upgrades/in-app-purchase": true,
"upgrades/premium-themes": false,
"persist-redux": false
"upgrades/premium-themes": false
},
"rtl": false,
"jetpack_min_version": "3.3",
Expand Down
31 changes: 15 additions & 16 deletions config/desktop.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,24 @@
"discover_blog_id": 53424024,
"discover_logged_out_redirect_url": "/",
"features": {
"desktop": true,
"fluid-width": true,
"oauth": true,
"code-splitting": false,
"always_use_logout_url": true,
"press-this": false,
"olark": false,
"login": false,

"ad-tracking": true,
"desktop-promo": false,
"always_use_logout_url": true,
"code-splitting": false,
"community-translator": true,
"desktop": true,
"desktop-promo": false,
"fluid-width": true,
"help": false,
"login": false,
"mailing-lists/unsubscribe": true,
"manage/ads": true,
"manage/ads/jetpack": true,
"manage/customize": true,
"manage/edit-user": true,
"manage/jetpack-plans": true,
"manage/jetpack": true,
"manage/menus-jetpack": true,
"manage/jetpack-plans": true,
"manage/menus": true,
"manage/menus-jetpack": true,
"manage/option_sync_non_public_post_stati": false,
"manage/pages": true,
"manage/people": true,
Expand All @@ -48,8 +44,8 @@
"manage/site-settings/analytics": true,
"manage/site-settings/delete-site": true,
"manage/stats": true,
"manage/themes-jetpack": true,
"manage/themes": true,
"manage/themes-jetpack": true,
"me/account": true,
"me/billing-history": true,
"me/find-friends": false,
Expand All @@ -60,14 +56,17 @@
"me/security/checkup": true,
"me/trophies": false,
"muse": true,
"oauth": true,
"olark": false,
"olark_use_wpcom_configuration": false,
"persist-redux": false,
"phone_signup": true,
"post-editor": true,
"post-editor/author-selector": true,
"post-editor/iframe-preview": true,
"post-editor/live-image-updates": true,
"post-editor/pages": true,
"rubberband-scroll-disable": true,
"press-this": false,
"reader": true,
"reader/activities": true,
"reader/discover": true,
Expand All @@ -77,6 +76,7 @@
"reader/recommendations": true,
"reader/share": true,
"reader/teams": true,
"rubberband-scroll-disable": true,
"settings/security/monitor": true,
"upgrades/checkout": true,
"upgrades/credit-cards": true,
Expand All @@ -88,8 +88,7 @@
"upgrades/domain-management/transfer": false,
"upgrades/domain-search": true,
"upgrades/in-app-purchase": false,
"upgrades/premium-themes": true,
"persist-redux": false
"upgrades/premium-themes": true
},
"rtl": false,
"jetpack_min_version": "3.3",
Expand Down
175 changes: 77 additions & 98 deletions config/development.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,66 +27,94 @@
"discover_blog_id": 53424024,
"discover_logged_out_redirect_url": "https://discover.wordpress.com",
"features": {
"accept-invite": true,
"ad-tracking": false,
"code-splitting": true,
"server-side-rendering": true,

"reader": true,
"reader/teams": true,
"reader/lists": true,
"reader/activities": true,
"reader/full-errors": true,
"reader/share": true,
"reader/following-edit": true,
"reader/recommendations": true,
"reader/list-management": true,
"reader/discover": true,

"post-editor": true,
"post-editor/iframe-preview": true,
"post-editor/live-image-updates": true,
"post-editor/pages": true,
"post-editor-github-link": false,
"post-editor/post-type-switch": false,
"post-editor/contact-form": true,
"post-editor/media-advanced": true,

"manage/media": true,
"manage/posts": true,
"community-translator": true,
"desktop-promo": true,
"devdocs": true,
"devdocs/redirect-loggedout-homepage": true,
"help": true,
"jetpack/calypso-first-signup-flow": true,
"jetpack_core_inline_update": true,
"keyboard-shortcuts": true,
"login": true,
"mailing-lists/unsubscribe": true,
"manage/add-people": true,
"manage/ads": true,
"manage/ads/jetpack": true,
"manage/customize": true,
"manage/drafts": true,
"manage/edit-user": true,
"manage/export": true,
"manage/import": true,
"manage/jetpack": true,
"manage/jetpack-plans": true,
"manage/media": true,
"manage/menus": true,
"manage/menus-jetpack": true,
"manage/option_sync_non_public_post_stati": true,
"manage/pages": true,
"manage/people": true,
"manage/people/readers": true,
"manage/plans": true,
"manage/plugins": true,
"manage/plugins/browser": true,
"manage/plugins/compatibility-warning": false,
"manage/plugins/cache": false,
"manage/plugins/compatibility-warning": false,
"manage/plugins/setup": true,

"manage/export": true,
"manage/posts": true,
"manage/security": true,
"manage/option_sync_non_public_post_stati": true,

"manage/stats": true,

"manage/sharing": true,
"manage/site-settings/analytics": true,
"manage/site-settings/delete-site": true,
"manage/import": true,
"manage/sharing": true,
"manage/people": true,
"manage/people/readers": true,
"manage/add-people": true,
"manage/edit-user": true,
"manage/jetpack": true,

"manage/menus": true,
"manage/menus-jetpack": true,
"manage/stats": true,
"manage/themes": true,
"manage/themes-jetpack": true,
"manage/themes/logged-out": true,
"manage/themes/details": true,
"manage/themes/logged-out": true,
"me/account": true,
"me/billing-history": true,
"me/find-friends": false,
"me/my-profile": true,
"me/next-steps": true,
"me/notifications": true,
"me/security": true,
"me/security/checkup": true,
"me/trophies": false,
"muse": true,
"network-connection": true,
"notifications2beta": true,
"olark": true,
"olark_use_wpcom_configuration": true,
"perfmon": false,
"persist-redux": false,
"phone_signup": true,
"post-editor": true,
"post-editor-github-link": false,
"post-editor/contact-form": true,
"post-editor/iframe-preview": true,
"post-editor/live-image-updates": true,
"post-editor/media-advanced": true,
"post-editor/pages": true,
"post-editor/post-type-switch": false,
"press-this": true,

"manage/plans": true,
"manage/jetpack-plans": true,

"reader": true,
"reader/activities": true,
"reader/discover": true,
"reader/following-edit": true,
"reader/full-errors": true,
"reader/list-management": true,
"reader/lists": true,
"reader/recommendations": true,
"reader/share": true,
"reader/teams": true,
"rubberband-scroll-disable": false,
"server-side-rendering": true,
"settings/security/monitor": true,
"settings/security/scan": true,
"support-user": true,
"sync-handler": true,
"upgrades/checkout": true,
"upgrades/credit-cards": true,
"upgrades/domain-management/contacts-privacy": true,
Expand All @@ -98,61 +126,12 @@
"upgrades/domain-search": true,
"upgrades/in-app-purchase": false,
"upgrades/premium-themes": true,

"manage/customize": true,

"manage/ads": true,
"manage/ads/jetpack": true,

"vip": false,
"vip/deploys": true,
"vip/billing": true,
"vip/support": true,
"vip/backups": true,
"vip/billing": true,
"vip/deploys": true,
"vip/logs": true,

"community-translator": true,

"keyboard-shortcuts": true,

"me/my-profile": true,
"me/account": true,
"me/billing-history": true,
"me/security": true,
"me/security/checkup": true,
"me/notifications": true,
"me/next-steps": true,
"me/find-friends": false,
"me/trophies": false,

"help": true,
"support-user": true,

"persist-redux": false,

"notifications2beta": true,
"muse": true,
"olark" : true,
"olark_use_wpcom_configuration": true,
"devdocs": true,
"devdocs/redirect-loggedout-homepage": true,
"jetpack_core_inline_update": true,
"phone_signup": true,
"login": true,

"rubberband-scroll-disable": false,
"network-connection": true,
"settings/security/monitor": true,
"settings/security/scan": true,
"ad-tracking": false,
"desktop-promo": true,

"accept-invite": true,
"perfmon": false,
"mailing-lists/unsubscribe": true,

"jetpack/calypso-first-signup-flow": true,
"sync-handler": true
"vip/support": true
},

"muse_supported_themes": [
Expand Down
Loading