Posts: Support requesting posts for current user in Redux posts state #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Posts
[Status] Needs Review
|
|
||
| /** | ||
| * Returns a function which, when invoked, triggers a network request to fetch | ||
| * posts for the specified query. |
There was a problem hiding this comment.
Should we add "across sites" here?
There was a problem hiding this comment.
Should we add "across sites" here?
Clarified in dc2fbbd
|
👍 Tested this out on the editor parent page selector and it works great. Feel free to 🚢 after this branch has been rebased, and lodash usage is updated. |
aduth
force-pushed
the
update/redux-posts-me
branch
from
d9ced0d to
3b722b4
Compare
aduth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Thanks @gwwar ! Rebased, squashed, and did some final testing. This'll be heading out the door this morning. |
aduth
added a commit
that referenced
this pull request
Feb 19, 2016
Posts: Support requesting posts for current user in Redux posts state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to update the posts Redux state handlers to offer an action creator for requesting all posts belonging to the current user.
Implementation notes:
The approach taken here was to convert the existing
siteQueriesandsiteQueriesLastPagereducer keys to more generalizedqueriesandqueriesLastPage, incorporating the optional site designation as part of the logic forgetSerializedPostsQuery. This has the added benefit of increasingly flattening the posts state structure.Testing instructions:
Ensure that existing usage of the posts Redux state remains unaffected. Specifically, this includes the parent page selector in the Calypso page editor. Specifically, repeat testing instructions from #2350.
Verify that Mocha tests pass by running
make testfrom the project root directory or directly fromclient/state/posts.