Domains: Allow empty names for TXT and MX records #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klimeryk
added
[Type] Enhancement
klimeryk
force-pushed
the
fix/allow-blank-mx-txt-records
branch
from
9e7623e to
5afdc55
Compare
klimeryk
changed the title
|
Root TXT records work but root MX records are not working with a |
umurkontaci
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
|
^ Disregard. DNS propagation weirdness was the reason. |
|
LGTM |
umurkontaci
added
[Status] Ready to Merge
and removed
[Status] Needs Author Reply
labels
klimeryk
pushed a commit
that referenced
this pull request
Feb 15, 2016
Domains: Allow empty names for TXT and MX records
This was referenced Feb 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes #234.
A separate PR is needed to add editing protected records (root A/AAAA or MX when email forwarding is enabled).
cc @umurkontaci @aidvu @bikedorkjon