Sidebar: Remove Plugins menu item for all sites except Jetpack ones #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanethomas
added
Jetpack
[Status] Needs Review
|
Works as expected. There is still some clean up that will need to happen which should probably be done in different PRs. |
enejb
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
I also tested, and it looks good to me. |
Tug
force-pushed
the
remove/ecommerce-plugin-sidebar
branch
from
323b322 to
666e54e
Compare
2 tasks
stephanethomas
force-pushed
the
remove/ecommerce-plugin-sidebar
branch
from
666e54e to
f54ae68
Compare
| classNames = require( 'classnames' ), | ||
| contains = require( 'lodash/collection/contains' ), |
There was a problem hiding this comment.
this will break if merged. contains is now includes and we can ditch the path
|
lodash 4 broke this one. Needs a rebase and fixup before proceeding. |
| has = require( 'lodash/object/has' ), | ||
| contains = require( 'lodash/collection/contains' ); | ||
| React = require( 'react' ), | ||
| startsWith = require( 'lodash/string/startsWith' ); |
There was a problem hiding this comment.
just need to drop the path
stephanethomas
force-pushed
the
remove/ecommerce-plugin-sidebar
branch
from
0ae6854 to
9afc01a
Compare
|
Rebased. |
stephanethomas
added
[Status] Ready to Merge
and removed
[Status] Needs Author Reply
labels
Thanks @stephanethomas ! |
|
Well thank you to you @blowery. You did all the hard work! |
This makes it more consistent with the logic to display the Plan menu item.
This clarifies the code by minimizing the number of feature gates.
This also switches part of a condition to make it easier to understand.
This make sure the Plugins page is not accessible from the sidebar for sites with a Business plan and ecommerce plugins.
stephanethomas
force-pushed
the
remove/ecommerce-plugin-sidebar
branch
from
9afc01a to
50c17bf
Compare
stephanethomas
added a commit
that referenced
this pull request
Feb 25, 2016
Sidebar: Remove Plugins menu item for all sites except Jetpack ones
Tug
added a commit
that referenced
this pull request
Feb 25, 2016
Remove business plugins (cleanup of #3079)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request disables the
Pluginsmenu item from the sidebar for all except Jetpack sites. This is a preliminary step to removing ecommerce plugins - it just makes sure thePluginspage is not linked from the sidebar for sites with a Business plan:Testing instructions
There are several conditions to test. First start with a single blog:
git checkout remove/ecommerce-plugin-sidebarand start your serverMy SitesPluginsmenu item in the sidebarMy SitesPluginsmenu item in the sidebarPluginsmenu item with aAddbutton in the sidebarNow repeat the same steps for a test account with several blogs:
My SitesPluginsmenu item in the sidebarPluginsmenu item in the sidebarMy SitesPluginsmenu item in the sidebarPluginsmenu item in the sidebarAll My SitesPluginsmenu item in the sidebarFinally let's add a Jetpack site to the mix:
My SitesPluginsmenu item in the sidebarMy SitesPluginsmenu item in the sidebarPluginsmenu item with aAddbutton in the sidebarAll My SitesPluginsmenu item with aAddbutton in the sidebarAdditional notes
The
Pluginspage is still accessible by entering the url directly in the browser.Reviews