Try catching JS errors and sending them to the API #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A gentle reminder to rename the first commit to something a bit more informative :). |
scruffian
force-pushed
the
revert-3034-revert-1949-try/catch-js-errors-2
branch
from
f705bb0 to
01d5c96
Compare
scruffian
added
[Status] Needs Review
|
@gravityrail that seems to have fixed it for me in IE11 (not logging in, but loading it at least). Thanks! |
|
@stephanethomas also tested this in IE11 and found no problems. I'm going to try merging again. |
scruffian
force-pushed
the
revert-3034-revert-1949-try/catch-js-errors-2
branch
from
01d5c96 to
5801ffb
Compare
scruffian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
scruffian
added a commit
that referenced
this pull request
Feb 4, 2016
…catch-js-errors-2 Try catching JS errors and sending them to the API
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sends JS errors to the REST API but it breaks in IE11. This was originally done in #1949