Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People: Send invites from section header #3046

Closed
wants to merge 4 commits into from

Conversation

roccotripaldi
Copy link
Member

This PR adds an invitation form, which can be toggled from the section header of the Team section.

screen shot 2016-02-03 at 12 51 03 pm

screen shot 2016-02-03 at 12 51 18 pm

screen shot 2016-02-03 at 12 51 36 pm

To test:

  • Checkout this branch and make run
  • Go to calypso.localhost:3000/people/team/$site where site is a wpcom site ( not currently supported for Jetpack sites )
  • In your JS console run localStorage.setItem( 'debug', 'calypso:invite-people-form' );
  • Reload the page
  • Click the Plus Icon in the section header
  • Try sending out some invites, and note the messages in your console

Still ToDo ( handle in an other PR )

  • handle success and error notices after clicking 'Invite'
  • support adding a custom message via modal
  • add to the section header for the other sections, 'followers', etc.
  • decide what happens when you click 'People > Add' in the sidebar
  • fine tune the design to be closer to Rick's mocks

CC @ebinnion @lezama @rickybanister

Allowing folks to send an invite from a new component in the
section header.
Updating styles to allow for placeholder text.
Adding styles for the invite form that can be toggled
within the section header.
@roccotripaldi roccotripaldi added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR People Management labels Feb 3, 2016
@roccotripaldi roccotripaldi self-assigned this Feb 3, 2016
@roccotripaldi roccotripaldi added this to the People Management: m7 milestone Feb 3, 2016
Adding action to send invites.
@roccotripaldi roccotripaldi force-pushed the try/send-invites-section-header branch from 17bbdb0 to 4ada7ed Compare February 3, 2016 18:10

render() {
return (
<div className="invite-form">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the display name should be PeopleSectionHeaderInviteForm and the class should be people-section-header__invite-form. This is a bit awkward since it's a separate component, but it's meant to be used as a child of people-section-header.

@ebinnion
Copy link
Contributor

ebinnion commented Feb 4, 2016

Closing in favor of #3058 for now.

@ebinnion ebinnion closed this Feb 4, 2016
@ebinnion ebinnion deleted the try/send-invites-section-header branch February 4, 2016 20:19
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 4, 2016
@lancewillett lancewillett removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants