Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow private registration to be removed from the cart #301

Merged
merged 1 commit into from
Nov 23, 2015
Merged

Don't allow private registration to be removed from the cart #301

merged 1 commit into from
Nov 23, 2015

Conversation

matthusby
Copy link
Contributor

Fixes #273

Testing

  1. git checkout update/keep-private-registration-in-cart
  2. Add a domain with private registration to your cart
  3. Verify that you cannot remove it.

screen shot 2015-11-19 at 1 34 24 pm

  • Code review
  • QA review

@matthusby
Don't allow private registration to be removed from the cart - cancel…
25885d2 
…ling private registration needs to an action taken by the user.
@matthusby matthusby added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. labels Nov 20, 2015
@matthusby matthusby self-assigned this Nov 20, 2015
@matthusby matthusby added this to the Purchases: v1 milestone Nov 20, 2015
@scruffian
Copy link
Member

LGTM 👍 🚢

@scruffian scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 23, 2015
matthusby added a commit that referenced this pull request Nov 23, 2015
@matthusby
Merge pull request #301 from Automattic/update/checkout-keep-private-…
fb637af 
…ragistration-in-cart

Don't allow private registration to be removed from the cart
@matthusby matthusby merged commit fb637af into master Nov 23, 2015
@matthusby matthusby deleted the update/checkout-keep-private-ragistration-in-cart branch November 23, 2015 15:47
@matthusby matthusby restored the update/checkout-keep-private-ragistration-in-cart branch November 23, 2015 22:11
@scruffian scruffian deleted the update/checkout-keep-private-ragistration-in-cart branch November 23, 2015 23:53
This was referenced Mar 17, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Nov 17, 2020
Open
@anarh anarh mentioned this pull request Jan 21, 2021
Open
@mdno mdno mentioned this pull request Jan 22, 2021
Open
@anarh anarh mentioned this pull request Mar 7, 2021
Open
@mdno mdno mentioned this pull request Mar 8, 2021
Open
@awaisab172 awaisab172 mentioned this pull request Mar 8, 2021
Open
@mayuba mayuba mentioned this pull request Mar 8, 2021
Open
@ajesse11x ajesse11x mentioned this pull request Mar 8, 2021
Open
This was referenced Sep 15, 2021
Open
Open
Open
@awaisab172 awaisab172 mentioned this pull request May 13, 2022
Open
@mdno mdno mentioned this pull request May 14, 2022
Open
@anarh anarh mentioned this pull request May 14, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2022
Open
@mdno mdno mentioned this pull request Oct 30, 2022
Open
@anarh anarh mentioned this pull request Oct 31, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Apr 30, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Jun 24, 2023
Open
@anarh anarh mentioned this pull request Nov 28, 2023
Open
@mdno mdno mentioned this pull request Nov 28, 2023
Open
@mayuba mayuba mentioned this pull request Nov 28, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Nov 28, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
@anarh anarh mentioned this pull request Nov 30, 2023
Open
This was referenced Nov 30, 2023
Open
Open
Open
@ajesse11x ajesse11x mentioned this pull request Nov 30, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Feb 2, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Mar 1, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Mar 22, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Apr 16, 2024
Open
@awaisab172 awaisab172 mentioned this pull request May 13, 2024
Open
@mayuba mayuba mentioned this pull request May 13, 2024
Open
@awaisab172 awaisab172 mentioned this pull request May 14, 2024
Open
@mdno mdno mentioned this pull request May 14, 2024
Open
@anarh anarh mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 23, 2024
Open
@awaisab172 awaisab172 mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthusby matthusby

Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthusby @scruffian @fabianapsimoes