-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Fix iOS 8.4 Focus Issues #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirming this fixes some nasty issues with elements intercepting clicks on iOS 8. Nice find. |
timmyc
added a commit
that referenced
this pull request
Nov 20, 2015
Editor: Fix iOS 8.4 Focus Issues
This was referenced Mar 17, 2020
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Notifications
Site notifications.
[Feature] Post/Page Editor
The editor for editing posts and pages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported having issues using the editor on an iPad Air2 running iOS 8.4. Upon testing, it was clear something was intercepting clicks from TinyMCE and even at times the title field. I discovered that the notifications panel, much like the
<EditorPreview />
, was using anopacity: 0
to hide itself when not active.The issue happens in iOS 9 as well - but does not happen on smaller viewports due to an existing css rule that uses
display: none
when the screen is<480px
. The screen grab below shows the positioning of the notifications iframe over the editor, and how only a very small slice is not covered, and as such is clickable:This click intercept happens in areas outside of the editor as well. Any place where the notifications drawer covers clickable elements, the iframe is intercepting clicks. For example visit a site post list and try to click "...More" under a post card, or clicking the "Comments" tab in the stats chart.
The fix in this branch is to simply apply
display: none
regardless of viewport size.To Test
Use an iOS device, preferably running iOS 8.4, or a simulator