Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fix iOS 8.4 Focus Issues #298

Merged
merged 1 commit into from
Nov 20, 2015
Merged

Editor: Fix iOS 8.4 Focus Issues #298

merged 1 commit into from
Nov 20, 2015

Conversation

timmyc
Copy link
Contributor

@timmyc timmyc commented Nov 20, 2015

A user reported having issues using the editor on an iPad Air2 running iOS 8.4. Upon testing, it was clear something was intercepting clicks from TinyMCE and even at times the title field. I discovered that the notifications panel, much like the <EditorPreview />, was using an opacity: 0 to hide itself when not active.

The issue happens in iOS 9 as well - but does not happen on smaller viewports due to an existing css rule that uses display: none when the screen is <480px. The screen grab below shows the positioning of the notifications iframe over the editor, and how only a very small slice is not covered, and as such is clickable:

ios-notif

This click intercept happens in areas outside of the editor as well. Any place where the notifications drawer covers clickable elements, the iframe is intercepting clicks. For example visit a site post list and try to click "...More" under a post card, or clicking the "Comments" tab in the stats chart.

The fix in this branch is to simply apply display: none regardless of viewport size.

To Test
Use an iOS device, preferably running iOS 8.4, or a simulator

  • Open the post editor
  • Ensure you can click focus into the title and TinyMCE editor areas

@timmyc timmyc added [Feature] Post/Page Editor The editor for editing posts and pages. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Notifications Site notifications. labels Nov 20, 2015
@timmyc timmyc self-assigned this Nov 20, 2015
@nylen
Copy link
Contributor

nylen commented Nov 20, 2015

Confirming this fixes some nasty issues with elements intercepting clicks on iOS 8. Nice find. :shipit:

@nylen nylen added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 20, 2015
timmyc added a commit that referenced this pull request Nov 20, 2015
@timmyc timmyc merged commit 48650cc into master Nov 20, 2015
@timmyc timmyc deleted the fix/editor/ios-8 branch November 20, 2015 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Notifications Site notifications. [Feature] Post/Page Editor The editor for editing posts and pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants