Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Break up monolithic _stats.scss file into appropriate component files #2386

Merged
merged 3 commits into from
Jan 14, 2016

Conversation

alternatekev
Copy link
Contributor

As part of the stats maintenance effort underway, we need to take the assets/stylesheets/sections/_stats.scss file and break it down:

  • It needs to be moved into the client/my-sites/stats/ directory
  • The rules inside of it need to be shuffled into their various component-specific directories, which now exist.

This PR touches the following components:

  • StatsChartTabs
  • StatsComments
  • StatsOverviewPlaceholder

In order to test:

  • Verify that the tabs show up correctly on the Day/Week/Month/Year charts
  • Verify that the comments list displays and functions correctly on the Insights page
  • Verify that when localStorage is cleared, you get visual placeholders on the modules while they're loading from the API

@alternatekev alternatekev added the [Feature] Stats Everything related to our analytics product at /stats/ label Jan 13, 2016
@alternatekev alternatekev added this to the Stats: Maintenance milestone Jan 13, 2016
@alternatekev
Copy link
Contributor Author

It looks like #2384 is going to be covering the StatsChartTabs component SCSS so skip that for now.

@alternatekev alternatekev added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2016
@timmyc
Copy link
Contributor

timmyc commented Jan 14, 2016

Did a quick pass of all the components loaded and in empty localstore state. I didn't see anything missing and since this is a copy and paste I wouldn't expect it ;)

So if you are also good with it Kevin lets get this merged in to prevent conflicts on other branches. End of an era :)

@timmyc timmyc added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 14, 2016
alternatekev added a commit that referenced this pull request Jan 14, 2016
Stats: Break up monolithic _stats.scss file into appropriate component files
@alternatekev alternatekev merged commit 7aa7fe3 into master Jan 14, 2016
@alternatekev alternatekev deleted the update/stats-scss branch January 14, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants