DocumentHead: Update the title when it is different than the saved title #22501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
Framework
[Status] Needs Review
|
I see something curious in my terminal when running this branch: I don't see that on master. Seems to happen after doing a force-refresh (Cmd-Shift-R) while looking at http://calypso.localhost:3000/store/YOURDOMAINHERE |
ryelle
force-pushed
the
fix/document-title-update
branch
from
ebf5171 to
4773074
Compare
|
@allendav that was a problem on master at the time, it's been fixed & I rebased this branch, so you shouldn't see it now. |
justinshreve
approved these changes
Mar 14, 2018
|
This doesn't work on other calypso pages; the title is not updated when going between sections. Closing this for another approach, as this is still an issue on smaller screens |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on the WooCommerce extension on smaller screens, I noticed that sometimes the title would disappear from the page title & this section:
Note, this section isn't currently visible in Store, to test you'll need to watch the title itself.
I tracked this to
documentHead.titlein redux state, which is cleared when the route is changed. In other sections of calypso, this is set either by directly calling an action, or using<DocumentHead>. In WC, we use the<DocumentHead>approach in our parent component, so this doesn't unmount/remount like some other sections of Calypso (settings, for example). This means if the document title doesn't change from section-to-section, the logic incomponentWillReceivePropsconsiders it "unchanged" and won't fire the action to update it (even though it's actually an empty string).This PR updates
DocumentHeadto check against the title currently saved in redux.To test
/store/orders/:site, or/store/reviews/:siteare good casesOrders < Site Title – WordPress.com(or Reviews < …)Site Title – WordPress.comDOCUMENT_HEAD_TITLE_SETaction fire.