Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEO: add SEO description field to editor if site has a JP Premium plan #22335

Merged
merged 1 commit into from
Feb 12, 2018
Merged

SEO: add SEO description field to editor if site has a JP Premium plan #22335

merged 1 commit into from
Feb 12, 2018

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 12, 2018

Fixes #22333

We want to check for Business, Enterprise, and Premium plans now.
Related: #21730

To test:

  1. Start from a site using Jetpack Premium, and where the SEO Tools are active.
  2. Go to https://wordpress.com/post/
  3. The SEO Description slider should be displayed in the editor's sidebar.

@jeherve
SEO: add SEO desc. field to editor if site has a JP Premium plan
7293e29 
Fixes #22333
We want to check for Business, Enterprise, and Premium plans now.
Related: #21730
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Normal Schedule for the next available opportuinity. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Plans [Feature] SEO Tools Tools for improving a site's search engine optimization. labels Feb 12, 2018
@jeherve jeherve requested a review from mattwiebe February 12, 2018 13:48
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/seo-description-jetpack-premium

mattwiebe
mattwiebe approved these changes Feb 12, 2018
View reviewed changes
Copy link
Contributor

@mattwiebe mattwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well, thanks for the catch. Our features are quite spread around :)

@jeherve jeherve merged commit eaa8728 into master Feb 12, 2018
@jeherve jeherve deleted the fix/seo-description-jetpack-premium branch February 12, 2018 19:41
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwiebe mattwiebe mattwiebe approved these changes

Assignees

@mattwiebe mattwiebe

@jeherve jeherve

Labels
[Feature] SEO Tools Tools for improving a site's search engine optimization. [Pri] Normal Schedule for the next available opportuinity. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeherve @matticbot @mattwiebe