Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: Use store’s address as default values for state & country in address component #19710

Merged
merged 2 commits into from
Nov 15, 2017

Conversation

ryelle
Copy link
Member

@ryelle ryelle commented Nov 13, 2017

Fixes #18902 — This PR updates the address country and state dropdown to get and use the store's country and state as the default values.

To test

You can view the old order creation page at /store/order/:site, this has the form with no address, only showing the defaults.

  • Check that the address state and country show the state/country of the store as saved on /store/settings/:site
  • Check that the defaults don't override a set address by editing the address of an existing order

@ryelle ryelle added Store [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 13, 2017
@matticbot
Copy link
Contributor

@ryelle ryelle self-assigned this Nov 13, 2017
Copy link
Contributor

@justinshreve justinshreve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM & tests correctly.

Copy link
Contributor

@allendav allendav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very nicely. No changes requested to code :shipit:

@ryelle ryelle added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 14, 2017
@ryelle ryelle merged commit 54f7fc5 into master Nov 15, 2017
@ryelle ryelle deleted the fix/18902-store-address-defaults branch November 15, 2017 15:14
rclations pushed a commit to rclations/wp-calypso that referenced this pull request Nov 15, 2017
…address component (Automattic#19710)

* Store: Use store’s address as default values for state & country in address components. Fixes Automattic#18902

* Update the orders create page to demo the address component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants