Store Orders: Add order status checks to editable sections #19707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ready been paid for
…ed, or there was a problem/refund)
ryelle
added
Store
[Status] Needs Review
timmyc
approved these changes
Nov 13, 2017
|
Still strikes me as odd that we can print labels for unpaid orders, but that's a separate issue #19079 |
|
You can add things like fees to any order you want by temporarily toggling the order state and then putting it back before saving. Maybe a subsequent issue/PR could examine preventing this
|
allendav
approved these changes
Nov 14, 2017
ryelle
added
[Status] Ready to Merge
and removed
[Status] Needs Review
12 tasks
rclations
pushed a commit
to rclations/wp-calypso
that referenced
this pull request
Nov 15, 2017
…c#19707) * Store Orders: Prevent editing of products/fees on orders that have already been paid for * Add ProtectFormGuard to prevent users leaving while edits are pending * Only allow editing of addresses before the order is “finished” (shipped, or there was a problem/refund)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps up all the features for editing orders 🎉 See #15681
Currently all orders are fully editable, no matter the order status. Obviously you don't want to be able to add products to an already-shipped order, so this PR adds in the status checks for editing the line items and billing/shipping addresses. It also adds the form guard to prevent the user from accidentally leaving a page with pending edits.
So you can edit products on any order that hasn't been paid, and edit addressed on any order that hasn't been shipped yet. A full table of functionality + status can be found at this comment: #15681 (comment)
Note: Editing the shipping fee is in another PR #19641, so I haven't left any testing instructions here – but it will also only be possible before the order is paid for.
To test