Settings: use form components in general section #1920
Conversation
In general settings, replace all form tags with their equivalent form components.
roccotripaldi
added
[Feature] Site Settings
| type="submit" | ||
|
|
||
| disabled={ this.state.fetchingSettings || this.state.submittingForm }> | ||
| ? <Button |
There was a problem hiding this comment.
In cases with condition ? someThing : null I like to use && and have seen it in common use around Calypso.
{ config.isEnabled( 'manage/option_sync_non_public_post_stati' ) &&
<Button
…
/>
}
There was a problem hiding this comment.
I wonder if a <ConfigurationGate key="manage/option..."><Button ... /> </ConfigurationGate> would make sense down the road...
There was a problem hiding this comment.
Though I guess that would always instantiate the Button, (or children) even if they're not needed. hrm.
Either way, not relevant to this PR really. :)
There was a problem hiding this comment.
Neat. i was not aware of <ConfigurationGate> Thanks for pointing it out.
There was a problem hiding this comment.
Neat. i was not aware of
<ConfigurationGate>Thanks for pointing it out.
It doesn't exist. :) Just saying that maybe it ought to, but I think I talked myself out of it.
There was a problem hiding this comment.
It doesn't exist. :)
haha. Now it's a scandal!
There was a problem hiding this comment.
ConfigurationGate sounds like a scandal ripped right from the headlines. :)
dmsnell
added
[Status] Ready to Merge
and removed
[Status] Needs Review
…-components Settings: use form components in general section
As part of the end-of-year maintenance, I plan to clean up the settings section a bit, a task that has been on my list for too long. see #88
This PR aims to replace all form tags in the general settings section with their equivalent form component.
Here is a before / after image. As you can see, nothing changes in appearance, which is expected.