Site Settings: abstract a site-centered no-sidebar scenario Card into a separate component #18273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaMag
added
[Feature] Site Settings
AnnaMag
force-pushed
the
update/site-settings-extract-card
branch
from
5c3fef3 to
eb749e6
Compare
Throughout the Jetpack Disconnect Flow we use a site-centered Card component without a navigation sidebar. Headers and subheaders vary, thus are included as props passed to the `CenteredCard` component. The goal is to decrease code repeats and aid reusability of such components in the future.
AnnaMag
added
the
[Status] Needs Review
AnnaMag
removed
the
[Status] Needs Review
|
Closing -- I think this is addressed well enough by composition as per #18749 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Create a Card component, which is centered on sites without a navigation sidebar.
Context:
Throughout the Jetpack Disconnect Flow we use a site-centered Card component with varying headers and subheaders, but repeated styling. Aside from cleaning code repeats for the Disconnect Flow, IMO this set-up could be reused in the other contexts (great for UX flows).
To test:
https://calypso.live/?branch=update/site-settings-extract-card
Refactor of #18119.
To test:
https://calypso.live/?branch=update/update/site-settings-extract-card
For Jetpack and non-Atomic sites:
/settings/disconnect-site/:site, where :site is the Jetpack site.Remaining sites have no access and should be redirected to
/settings/general/.Visuals:
