Plugin Browser: Use the no result component to render no results in plugin browser search #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
Jetpack
[Status] Needs Review
|
I wanted to get fancy with this, but I can't draw a knotted cord on the plug, so I tried this instead (it has a littttttle bit of dimension).
Thoughts @drw158 @MichaelArestad |
|
codewise looks and works great ... we both can wait for an image to add, or merge it and the do another PR adding the image |
rickybanister
added
[Status] Ready to Merge
and removed
[Status] Needs Design Review
|
Since a new issue is open for the icon, let's just merge this for now. 🚢 |
enejb
force-pushed
the
fix/829-plugin-search-no-result-browser
branch
from
3efa67a to
e6868d7
Compare
enejb
added a commit
that referenced
this pull request
Dec 21, 2015
…ult-browser Plugin Browser: Use the no result component to render no results in plugin browser search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #829.
Before:
After:
To test
visit http://calypso.localhost:3000/plugins/browse?s=automatticasdasd
Notice that we don't have a icon yet. This will be updated once we have one.
cc @johnHackworth, @rickybanister
Related #1772